Better runtime type checks.

frog/presubmit.py

 #!/usr/bin/env python
 # Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 import os
 import subprocess
 import sys
 import time
 
@@ skipping 33 matching lines @@
   sys.stderr.write('Command failed:\n%s\n' % quoted_arguments)
   if stdout:
     sys.stderr.write(stdout)
 
 
 def main(args):
   def b(s):
     """Adds ANSI escape-code for bold-face"""
     return "\033[1m%s\033[0m" % s
 
+  # VM Checked, produces checked
   print 'Started'
   start = time.time()
   RunCommand('./frog.py',
              '--vm_flags=--compile_all --enable_type_checks --enable_asserts',
-             '--',  '--out=frogsh', 'frog.dart')
+             '--', '--enable_type_checks', '--out=frogsh', 'frog.dart')
   elapsed = time.time() - start
   print 'Compiling on Dart VM took %s seconds %s' % (b(elapsed),
                                                      b('in checked mode'))
+
+  # VM Normal, produces checked
   start = time.time()
-  RunCommand('./frog.py', '--out=frogsh', 'frog.dart')
+  RunCommand('./frog.py', '--out=frogsh', '--enable_type_checks', 'frog.dart')
   elapsed = time.time() - start
   print 'Compiling on Dart VM took %s seconds' % b(elapsed)
+
+  # Selfhost Checked

[Jennifer Messerly, 2011/11/05 00:45:11]

The speed/size is reasonable enough, so I just turned on --enable_type_checks.

   start = time.time()
-  RunCommand('./frogsh', '--out=frogsh', 'frog.dart', 'tests/hello.dart')
+  RunCommand('./frogsh', '--out=frogsh', '--enable_type_checks', 'frog.dart',
+             '--enable_type_checks', 'tests/hello.dart')
   elapsed = time.time() - start
   size = os.path.getsize('./frogsh') / 1024
-  print 'Bootstrapping took %s seconds' % b(elapsed)
-  print 'Generated frogsh is \033[1m%d\033[0m kB' % size
+  print 'Bootstrapping took %s seconds %s' % (b(elapsed), b('in checked mode'))
+  print 'Generated %s frogsh is %s kB' % (b('checked'), b(size))
 
   RunCommand('../tools/build.py', '--mode=release')
   test_cmd = ['../tools/test.py', '--component=frog,frogsh,leg',
               '--report', '--timeout=5', '--progress=color',
               '--mode=release']
   if args[1:]:
     test_cmd.extend(args[1:])
   else:
     test_cmd.extend(['language', 'corelib', 'leg', 'peg'])
   RunCommand(*test_cmd, verbose=True)
@@ skipping 18 matching lines @@
                    '--vm_flags=--enable_type_checks --enable_asserts',
                    '--', '--enable_leg', '--verbose', '--throw_on_errors',
                    filename, pattern=pattern, exit_code=vm_exit_code)
 
 if __name__ == '__main__':
   try:
     sys.exit(main(sys.argv))
   except Error as e:
     sys.stderr.write('%s\n' % e)
     sys.exit(1)