Change mod_for_test_script to make it work with arm os image.

Change mod_for_test_script to make it work with arm os image.

Get rid of chroot inside this script, and not mounting mod_for_test_scripts into rootfs any more.

The reason caused the failure here is once you chroot into the mounted rootfs directory, all binaries were searched inside the rootfs. But all binaries inside the arm rootfs was for arm hardware, so not executable on the host linux machine(intel).

[ericli, 2010-03-12 20:00:35]

Initial code review request.

[kmixter1, 2010-03-12 22:04:59]

http://codereview.chromium.org/845007/diff/2001/3002
File src/scripts/mod_for_test_scripts/300changePassword (right):

http://codereview.chromium.org/845007/diff/2001/3002#newcode7
src/scripts/mod_for_test_scripts/300changePassword:7: # reset root password to
test0000 (4 zeroes).
Why is this no longer setting chronos password?

http://codereview.chromium.org/845007/diff/2001/3004
File src/scripts/mod_for_test_scripts/601autoStartSshd (right):

http://codereview.chromium.org/845007/diff/2001/3004#newcode7
src/scripts/mod_for_test_scripts/601autoStartSshd:7: # start sshd at os init
time.
You can just remove this file entirely.  /etc/init/sshd.conf doesn't work with
portage build and instead openssh-server.conf from non-modified image is
enabling ssh.

http://codereview.chromium.org/845007/diff/2001/3004#newcode9
src/scripts/mod_for_test_scripts/601autoStartSshd:9: cp -pf
${GCLIENT_ROOT}/src/scripts/mod_for_test_scripts/sshd.conf
${ROOT_FS_DIR}/etc/init/sshd.conf
80 chars

http://codereview.chromium.org/845007/diff/2001/3007
File src/scripts/mod_for_test_scripts/test_setup.sh (right):

http://codereview.chromium.org/845007/diff/2001/3007#newcode7
src/scripts/mod_for_test_scripts/test_setup.sh:7: for SCRIPT in
${GCLIENT_ROOT}/src/scripts/mod_for_test_scripts/[0-9][0-9][0-9]*[!$~]
80 chars

[ericli, 2010-03-12 23:54:29]

PTAL.

On 2010/03/12 22:04:59, kmixter1 wrote:
> http://codereview.chromium.org/845007/diff/2001/3002
> File src/scripts/mod_for_test_scripts/300changePassword (right):
> 
> http://codereview.chromium.org/845007/diff/2001/3002#newcode7
> src/scripts/mod_for_test_scripts/300changePassword:7: # reset root password to
> test0000 (4 zeroes).
> Why is this no longer setting chronos password?
> 
> http://codereview.chromium.org/845007/diff/2001/3004
> File src/scripts/mod_for_test_scripts/601autoStartSshd (right):
> 
> http://codereview.chromium.org/845007/diff/2001/3004#newcode7
> src/scripts/mod_for_test_scripts/601autoStartSshd:7: # start sshd at os init
> time.
> You can just remove this file entirely.  /etc/init/sshd.conf doesn't work with
> portage build and instead openssh-server.conf from non-modified image is
> enabling ssh.
> 
> http://codereview.chromium.org/845007/diff/2001/3004#newcode9
> src/scripts/mod_for_test_scripts/601autoStartSshd:9: cp -pf
> ${GCLIENT_ROOT}/src/scripts/mod_for_test_scripts/sshd.conf
> ${ROOT_FS_DIR}/etc/init/sshd.conf
> 80 chars
> 
> http://codereview.chromium.org/845007/diff/2001/3007
> File src/scripts/mod_for_test_scripts/test_setup.sh (right):
> 
> http://codereview.chromium.org/845007/diff/2001/3007#newcode7
> src/scripts/mod_for_test_scripts/test_setup.sh:7: for SCRIPT in
> ${GCLIENT_ROOT}/src/scripts/mod_for_test_scripts/[0-9][0-9][0-9]*[!$~]
> 80 chars

[ericli, 2010-03-12 23:54:35]

http://codereview.chromium.org/845007/diff/2001/3002
File src/scripts/mod_for_test_scripts/300changePassword (right):

http://codereview.chromium.org/845007/diff/2001/3002#newcode7
src/scripts/mod_for_test_scripts/300changePassword:7: # reset root password to
test0000 (4 zeroes).
user chronos is not used in test automation so far. We use root user.

and I heard chronos user might be removed in future build.


On 2010/03/12 22:05:00, kmixter1 wrote:
> Why is this no longer setting chronos password?

http://codereview.chromium.org/845007/diff/2001/3004
File src/scripts/mod_for_test_scripts/601autoStartSshd (right):

http://codereview.chromium.org/845007/diff/2001/3004#newcode7
src/scripts/mod_for_test_scripts/601autoStartSshd:7: # start sshd at os init
time.
yes.

On 2010/03/12 22:05:00, kmixter1 wrote:
> You can just remove this file entirely.  /etc/init/sshd.conf doesn't work with
> portage build and instead openssh-server.conf from non-modified image is
> enabling ssh.

[ericli, 2010-03-13 01:01:17]

chronos password was reset to test0000 in the latest patch.
PTAL.

[robotboy, 2010-03-13 01:07:17]

It looks like there is still some issue with the enabling of sshd (output
below).  I just pulled this so I think I have the latest patchset.

Thanks,
     Anton

(cros-chroot) robotboy@servo ~/trunk/src/scripts $ ./mod_image_for_test.sh
--board voguev210
Modifying image
/home/robotboy/trunk/src/build/images/voguev210/0.6.37.201003130008-a1/rootfs.image
for test; are you sure (y/N)? y
Recording production image size.
Copying public keys
Enabling sshd.
cp: cannot stat `sshd.conf': No such file or directory
chmod: cannot access `/etc/init/sshd.conf': No such file or directory
chown: cannot access `/etc/init/sshd.conf': No such file or directory
Enabling autologin using autox.
sudo: lsof: command not found


On Fri, Mar 12, 2010 at 5:01 PM, <ericli@chromium.org> wrote:

> chronos password was reset to test0000 in the latest patch.
> PTAL.
>
>
> http://codereview.chromium.org/845007
>

[ericli, 2010-03-13 01:14:02]

Chris just removed sshd.conf in another CL today.

Resync you client and repatch. :)

On Fri, Mar 12, 2010 at 5:07 PM, Anton Staaf <robotboy@chromium.org> wrote:

> It looks like there is still some issue with the enabling of sshd (output
> below).  I just pulled this so I think I have the latest patchset.
>
> Thanks,
>      Anton
>
> (cros-chroot) robotboy@servo ~/trunk/src/scripts $ ./mod_image_for_test.sh
> --board voguev210
> Modifying image
>
/home/robotboy/trunk/src/build/images/voguev210/0.6.37.201003130008-a1/rootfs.image
> for test; are you sure (y/N)? y
> Recording production image size.
> Copying public keys
> Enabling sshd.
> cp: cannot stat `sshd.conf': No such file or directory
> chmod: cannot access `/etc/init/sshd.conf': No such file or directory
> chown: cannot access `/etc/init/sshd.conf': No such file or directory
> Enabling autologin using autox.
> sudo: lsof: command not found
>
>
> On Fri, Mar 12, 2010 at 5:01 PM, <ericli@chromium.org> wrote:
>
>> chronos password was reset to test0000 in the latest patch.
>> PTAL.
>>
>>
>> http://codereview.chromium.org/845007
>>
>
>


-- 
Eric Li
李咏竹
Google Kirkland

[ericli, 2010-03-13 05:53:10]

you are calling it inside chroot already, dont do this. :)

(cros-chroot) robotboy@servo ~/trunk/src/scripts $ ./mod_image_for_test.sh
--board voguev210

On Fri, Mar 12, 2010 at 5:44 PM, Anton Staaf <robotboy@google.com> wrote:

> Indeed.  that must have happened right after I last synced.  :)  Now the
> only issue seems to be the missing lsof.
>
> -Anton
>
> (cros-chroot) robotboy@servo ~/trunk/src/scripts $ ./mod_image_for_test.sh
> --board voguev210
> Modifying image
>
/home/robotboy/trunk/src/build/images/voguev210/0.6.37.201003130008-a1/rootfs.image
> for test; are you sure (y/N)? y
> Recording production image size.
>   Not modifying existing
>
/home/robotboy/trunk/src/build/images/voguev210/0.6.37.201003130008-a1/rootfs/root/bytes-rootfs-prod.
> Copying public keys
> Enabling autologin using autox.
> sudo: lsof: command not found
>
>
> On Fri, Mar 12, 2010 at 5:13 PM, Eric Li(李咏竹) <ericli@chromium.org> wrote:
>
>> Chris just removed sshd.conf in another CL today.
>>
>> Resync you client and repatch. :)
>>
>>
>> On Fri, Mar 12, 2010 at 5:07 PM, Anton Staaf <robotboy@chromium.org>wrote:
>>
>>> It looks like there is still some issue with the enabling of sshd (output
>>> below).  I just pulled this so I think I have the latest patchset.
>>>
>>> Thanks,
>>>      Anton
>>>
>>> (cros-chroot) robotboy@servo ~/trunk/src/scripts $
>>> ./mod_image_for_test.sh --board voguev210
>>> Modifying image
>>>
/home/robotboy/trunk/src/build/images/voguev210/0.6.37.201003130008-a1/rootfs.image
>>> for test; are you sure (y/N)? y
>>> Recording production image size.
>>> Copying public keys
>>> Enabling sshd.
>>> cp: cannot stat `sshd.conf': No such file or directory
>>> chmod: cannot access `/etc/init/sshd.conf': No such file or directory
>>> chown: cannot access `/etc/init/sshd.conf': No such file or directory
>>> Enabling autologin using autox.
>>> sudo: lsof: command not found
>>>
>>>
>>> On Fri, Mar 12, 2010 at 5:01 PM, <ericli@chromium.org> wrote:
>>>
>>>> chronos password was reset to test0000 in the latest patch.
>>>> PTAL.
>>>>
>>>>
>>>> http://codereview.chromium.org/845007
>>>>
>>>
>>>
>>
>>
>> --
>> Eric Li
>> 李咏竹
>> Google Kirkland
>>
>>
>>
>


-- 
Eric Li
李咏竹
Google Kirkland

[ericli, 2010-03-15 22:03:10]

One of the nice things of this script is it could work on image on any path
by given --image command arg. If it is inside chroot, the ability to mod any
image is limited to the chroot boundary, which is a lose for test.

Also, lsof is not available inside chroot, which already discovered by you.
;)

On Mon, Mar 15, 2010 at 2:52 PM, Anton Staaf <robotboy@google.com> wrote:

>     Why can't I call this inside the chroot?  Everything else is done in
> the chroot...  Is there a technical reason for this?
>
>     Thanks,
>         Anton
>
>
> On Fri, Mar 12, 2010 at 10:53 PM, Eric Li(李咏竹) <ericli@chromium.org>wrote:
>
>> you are calling it inside chroot already, dont do this. :)
>>
>>
>> (cros-chroot) robotboy@servo ~/trunk/src/scripts $
>> ./mod_image_for_test.sh --board voguev210
>>
>> On Fri, Mar 12, 2010 at 5:44 PM, Anton Staaf <robotboy@google.com> wrote:
>>
>>> Indeed.  that must have happened right after I last synced.  :)  Now the
>>> only issue seems to be the missing lsof.
>>>
>>> -Anton
>>>
>>> (cros-chroot) robotboy@servo ~/trunk/src/scripts $
>>> ./mod_image_for_test.sh --board voguev210
>>> Modifying image
>>>
/home/robotboy/trunk/src/build/images/voguev210/0.6.37.201003130008-a1/rootfs.image
>>> for test; are you sure (y/N)? y
>>> Recording production image size.
>>>   Not modifying existing
>>>
/home/robotboy/trunk/src/build/images/voguev210/0.6.37.201003130008-a1/rootfs/root/bytes-rootfs-prod.
>>> Copying public keys
>>> Enabling autologin using autox.
>>> sudo: lsof: command not found
>>>
>>>
>>> On Fri, Mar 12, 2010 at 5:13 PM, Eric Li(李咏竹) <ericli@chromium.org>wrote:
>>>
>>>> Chris just removed sshd.conf in another CL today.
>>>>
>>>> Resync you client and repatch. :)
>>>>
>>>>
>>>> On Fri, Mar 12, 2010 at 5:07 PM, Anton Staaf <robotboy@chromium.org>wrote:
>>>>
>>>>> It looks like there is still some issue with the enabling of sshd
>>>>> (output below).  I just pulled this so I think I have the latest patchset.
>>>>>
>>>>> Thanks,
>>>>>      Anton
>>>>>
>>>>> (cros-chroot) robotboy@servo ~/trunk/src/scripts $
>>>>> ./mod_image_for_test.sh --board voguev210
>>>>> Modifying image
>>>>>
/home/robotboy/trunk/src/build/images/voguev210/0.6.37.201003130008-a1/rootfs.image
>>>>> for test; are you sure (y/N)? y
>>>>> Recording production image size.
>>>>> Copying public keys
>>>>> Enabling sshd.
>>>>> cp: cannot stat `sshd.conf': No such file or directory
>>>>> chmod: cannot access `/etc/init/sshd.conf': No such file or directory
>>>>> chown: cannot access `/etc/init/sshd.conf': No such file or directory
>>>>> Enabling autologin using autox.
>>>>> sudo: lsof: command not found
>>>>>
>>>>>
>>>>> On Fri, Mar 12, 2010 at 5:01 PM, <ericli@chromium.org> wrote:
>>>>>
>>>>>> chronos password was reset to test0000 in the latest patch.
>>>>>> PTAL.
>>>>>>
>>>>>>
>>>>>> http://codereview.chromium.org/845007
>>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Eric Li
>>>> 李咏竹
>>>> Google Kirkland
>>>>
>>>>
>>>>
>>>
>>
>>
>> --
>> Eric Li
>> 李咏竹
>> Google Kirkland
>>
>>
>>
>


-- 
Eric Li
李咏竹
Google Kirkland

[robotboy, 2010-03-16 00:26:57]

OK, LGTM.

I have a CL going through to add lsof support inside the chroot and it looks
like that makes it work there.  There is no reason to prevent it from working
inside the chroot.

[robotboy, 2010-03-16 00:29:01]

And thanks again for getting this working on ARM.  :)

    -Anton

On Mon, Mar 15, 2010 at 5:26 PM, <robotboy@chromium.org> wrote:

> OK, LGTM.
>
> I have a CL going through to add lsof support inside the chroot and it
> looks
> like that makes it work there.  There is no reason to prevent it from
> working
> inside the chroot.
>
>
> http://codereview.chromium.org/845007
>

[ericli, 2010-03-16 00:29:07]

OK, I will push this for now.

We can revisit it for chroot later.

On 2010/03/16 00:26:57, robotboy wrote:
> OK, LGTM.
> 
> I have a CL going through to add lsof support inside the chroot and it looks
> like that makes it work there.  There is no reason to prevent it from working
> inside the chroot.