Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3091)

Unified Diff: base/base.gypi

Issue 8440064: fix sources list for symbolize (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/base.gypi
diff --git a/base/base.gypi b/base/base.gypi
index e2f0a7d8921c8d3415df5ab6903d6708ed819ed2..122c550a621f2557b97104f3f128629c24b2b76c 100644
--- a/base/base.gypi
+++ b/base/base.gypi
@@ -784,10 +784,15 @@
],
'sources': [
'third_party/symbolize/symbolize.cc',
M-A Ruel 2011/11/07 16:22:47 Please keep in order.
ensonic 2011/11/07 16:48:06 sorted the files.
+ 'third_party/symbolize/symbolize.h',
'third_party/symbolize/demangle.cc',
- ],
- 'include_dirs': [
- '..',
+ 'third_party/symbolize/demangle.h',
+ 'third_party/symbolize/utilities.h',
+ 'third_party/symbolize/config.h',
+ # WTF: logging.h is empty, raw_logging #defines a stub that is used just one
M-A Ruel 2011/11/07 16:22:47 It's probably so base/logging.h is not used? You s
ensonic 2011/11/07 16:48:06 Lets keep the files. That probably makes updating
+ # can we remove those two files?
+ 'third_party/symbolize/glog/logging.h',
+ 'third_party/symbolize/glog/raw_logging.h',
],
},
{
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698