Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Side by Side Diff: base/base.gypi

Issue 8440064: fix sources list for symbolize (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'target_defaults': { 6 'target_defaults': {
7 'variables': { 7 'variables': {
8 'base_target': 0, 8 'base_target': 0,
9 }, 9 },
10 'target_conditions': [ 10 'target_conditions': [
(...skipping 765 matching lines...) Expand 10 before | Expand all | Expand 10 after
776 ], 776 ],
777 },], 777 },],
778 ], 778 ],
779 'cflags': [ 779 'cflags': [
780 '-Wno-sign-compare', 780 '-Wno-sign-compare',
781 ], 781 ],
782 'cflags!': [ 782 'cflags!': [
783 '-Wextra', 783 '-Wextra',
784 ], 784 ],
785 'sources': [ 785 'sources': [
786 'third_party/symbolize/symbolize.cc', 786 'third_party/symbolize/symbolize.cc',
M-A Ruel 2011/11/07 16:22:47 Please keep in order.
ensonic 2011/11/07 16:48:06 sorted the files.
787 'third_party/symbolize/symbolize.h',
787 'third_party/symbolize/demangle.cc', 788 'third_party/symbolize/demangle.cc',
788 ], 789 'third_party/symbolize/demangle.h',
789 'include_dirs': [ 790 'third_party/symbolize/utilities.h',
790 '..', 791 'third_party/symbolize/config.h',
792 # WTF: logging.h is empty, raw_logging #defines a stub that is used just one
M-A Ruel 2011/11/07 16:22:47 It's probably so base/logging.h is not used? You s
ensonic 2011/11/07 16:48:06 Lets keep the files. That probably makes updating
793 # can we remove those two files?
794 'third_party/symbolize/glog/logging.h',
795 'third_party/symbolize/glog/raw_logging.h',
791 ], 796 ],
792 }, 797 },
793 { 798 {
794 'target_name': 'xdg_mime', 799 'target_name': 'xdg_mime',
795 'type': 'static_library', 800 'type': 'static_library',
796 'toolsets': ['host', 'target'], 801 'toolsets': ['host', 'target'],
797 'variables': { 802 'variables': {
798 'chromium_code': 0, 803 'chromium_code': 0,
799 }, 804 },
800 'cflags!': [ 805 'cflags!': [
(...skipping 15 matching lines...) Expand all
816 'third_party/xdg_mime/xdgmimemagic.c', 821 'third_party/xdg_mime/xdgmimemagic.c',
817 'third_party/xdg_mime/xdgmimemagic.h', 822 'third_party/xdg_mime/xdgmimemagic.h',
818 'third_party/xdg_mime/xdgmimeparent.c', 823 'third_party/xdg_mime/xdgmimeparent.c',
819 'third_party/xdg_mime/xdgmimeparent.h', 824 'third_party/xdg_mime/xdgmimeparent.h',
820 ], 825 ],
821 }, 826 },
822 ], 827 ],
823 }], 828 }],
824 ], 829 ],
825 } 830 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698