fix sources list for symbolize

Fix sources list for symbolize.

BUG=105855
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112200

[ensonic, 2011-11-03 10:29:40]

Let me know if I should rather remove the two glog includes and the one disabled
use of the log macro (RAW_LOG in symbolize.cc).

[M-A Ruel, 2011-11-07 16:22:47]

http://codereview.chromium.org/8440064/diff/1/base/base.gypi
File base/base.gypi (right):

http://codereview.chromium.org/8440064/diff/1/base/base.gypi#newcode786
base/base.gypi:786: 'third_party/symbolize/symbolize.cc',
Please keep in order.

http://codereview.chromium.org/8440064/diff/1/base/base.gypi#newcode792
base/base.gypi:792: # WTF: logging.h is empty, raw_logging #defines a stub that
is used just one
It's probably so base/logging.h is not used? You should analyse more and comment
accordingly if it is confusing.

[ensonic, 2011-11-07 16:48:06]

http://codereview.chromium.org/8440064/diff/1/base/base.gypi
File base/base.gypi (right):

http://codereview.chromium.org/8440064/diff/1/base/base.gypi#newcode786
base/base.gypi:786: 'third_party/symbolize/symbolize.cc',
On 2011/11/07 16:22:47, Marc-Antoine Ruel wrote:
> Please keep in order.

sorted the files.

http://codereview.chromium.org/8440064/diff/1/base/base.gypi#newcode792
base/base.gypi:792: # WTF: logging.h is empty, raw_logging #defines a stub that
is used just one
On 2011/11/07 16:22:47, Marc-Antoine Ruel wrote:
> It's probably so base/logging.h is not used? You should analyse more and
comment
> accordingly if it is confusing.

Lets keep the files. That probably makes updating easier.

[M-A Ruel, 2011-11-29 15:25:55]

lgtm

[commit-bot: I haz the power, 2011-11-29 15:26:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ensonic@google.com/8440064/6001

[commit-bot: I haz the power, 2011-11-29 15:51:01]

Try job failure for 8440064-6001 (retry) on linux_clang for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...

[M-A Ruel, 2011-11-29 15:57:39]

On 2011/11/29 15:51:01, I haz the power (commit-bot) wrote:
> Try job failure for 8440064-6001 (retry) on linux_clang for step "compile"
> (clobber build).
> It's a second try, previously, step "compile" failed.
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...

Looks genuine, please fix.

[ensonic, 2011-11-29 16:05:25]

On 2011/11/29 15:57:39, Marc-Antoine Ruel wrote:
> On 2011/11/29 15:51:01, I haz the power (commit-bot) wrote:
> > Try job failure for 8440064-6001 (retry) on linux_clang for step "compile"
> > (clobber build).
> > It's a second try, previously, step "compile" failed.
> >
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...
> 
> Looks genuine, please fix.

done.

[M-A Ruel, 2011-11-29 16:09:23]

lgtm

[commit-bot: I haz the power, 2011-11-29 16:09:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ensonic@google.com/8440064/10002

[M-A Ruel, 2011-11-29 16:13:49]

On 2011/11/29 16:09:31, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
> https://chromium-status.appspot.com/cq/ensonic%40google.com/8440064/10002

I cancelled it. Just update the CL description with the bug and check the commit
check box again.

[commit-bot: I haz the power, 2011-11-30 09:53:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ensonic@google.com/8440064/10002

[commit-bot: I haz the power, 2011-11-30 11:47:04]

Change committed as 112200