Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Unified Diff: content/utility/utility_thread_impl.cc

Issue 8440042: Send the index in the canonical list over IPC when using the OOP plugin loader. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/common/utility_messages.h ('K') | « content/common/utility_messages.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/utility/utility_thread_impl.cc
diff --git a/content/utility/utility_thread_impl.cc b/content/utility/utility_thread_impl.cc
index f53fcd860d4a4737a8780ab584fe2a0dab392fb6..93b906dd5fbf41d0b4fb01f79348058767df66ed 100644
--- a/content/utility/utility_thread_impl.cc
+++ b/content/utility/utility_thread_impl.cc
@@ -127,21 +127,19 @@ void UtilityThreadImpl::OnLoadPlugins(
webkit::npapi::PluginList* plugin_list =
webkit::npapi::PluginList::Singleton();
- for (std::vector<FilePath>::const_iterator it = plugin_paths.begin();
- it != plugin_paths.end();
- ++it) {
+ for (size_t i = 0; i < plugin_paths.size(); ++i) {
ScopedVector<webkit::npapi::PluginGroup> plugin_groups;
- plugin_list->LoadPlugin(*it, &plugin_groups);
+ plugin_list->LoadPlugin(plugin_paths[i], &plugin_groups);
if (plugin_groups.empty()) {
- Send(new UtilityHostMsg_LoadPluginFailed(*it));
+ Send(new UtilityHostMsg_LoadPluginFailed(i, plugin_paths[i]));
continue;
}
const webkit::npapi::PluginGroup* group = plugin_groups[0];
DCHECK_EQ(group->web_plugin_infos().size(), 1u);
- Send(new UtilityHostMsg_LoadedPlugin(group->web_plugin_infos().front()));
+ Send(new UtilityHostMsg_LoadedPlugin(i, group->web_plugin_infos().front()));
Bernhard Bauer 2011/11/02 16:03:52 I still feel a little bit silly just sending an in
Robert Sesek 2011/11/02 16:26:28 I think the index is fine to send. Sending the ori
}
ReleaseProcessIfNeeded();
« content/common/utility_messages.h ('K') | « content/common/utility_messages.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698