Send the index in the canonical list over IPC when using the OOP plugin loader.

content/utility/utility_thread_impl.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/utility/utility_thread_impl.h"
 
 #include <stddef.h>
 
 #include "base/file_path.h"
 #include "base/memory/scoped_vector.h"
@@ skipping 109 matching lines @@
 void UtilityThreadImpl::OnBatchModeFinished() {
   ChildProcess::current()->ReleaseProcess();
 }
 
 #if defined(OS_POSIX)
 void UtilityThreadImpl::OnLoadPlugins(
     const std::vector<FilePath>& plugin_paths) {
   webkit::npapi::PluginList* plugin_list =
       webkit::npapi::PluginList::Singleton();
 
-  for (std::vector<FilePath>::const_iterator it = plugin_paths.begin();
-       it != plugin_paths.end();
-       ++it) {
+  for (size_t i = 0; i < plugin_paths.size(); ++i) {
     ScopedVector<webkit::npapi::PluginGroup> plugin_groups;
-    plugin_list->LoadPlugin(*it, &plugin_groups);
+    plugin_list->LoadPlugin(plugin_paths[i], &plugin_groups);
 
     if (plugin_groups.empty()) {
-      Send(new UtilityHostMsg_LoadPluginFailed(*it));
+      Send(new UtilityHostMsg_LoadPluginFailed(i, plugin_paths[i]));
       continue;
     }
 
     const webkit::npapi::PluginGroup* group = plugin_groups[0];
     DCHECK_EQ(group->web_plugin_infos().size(), 1u);
 
-    Send(new UtilityHostMsg_LoadedPlugin(group->web_plugin_infos().front()));
+    Send(new UtilityHostMsg_LoadedPlugin(i, group->web_plugin_infos().front()));

[Bernhard Bauer, 2011/11/02 16:03:52]

I still feel a little bit silly just sending an increasing index back. I guess
we could send the original path instead of the index?

[Robert Sesek, 2011/11/02 16:26:28]

I think the index is fine to send. Sending the original path is more data that
we likely wouldn't use.

   }
 
   ReleaseProcessIfNeeded();
 }
 #endif