Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Unified Diff: content/common/utility_messages.h

Issue 8440042: Send the index in the canonical list over IPC when using the OOP plugin loader. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/utility_messages.h
diff --git a/content/common/utility_messages.h b/content/common/utility_messages.h
index 4b197acf013a30ddac4dc7a2f220bac85199cfc4..08fd372052873137b814282cd5b7beb43d7b27e2 100644
--- a/content/common/utility_messages.h
+++ b/content/common/utility_messages.h
@@ -69,10 +69,12 @@ IPC_MESSAGE_CONTROL1(UtilityHostMsg_InjectIDBKey_Finished,
#if defined(OS_POSIX)
// Notifies the browser when a plugin failed to load so the two processes can
// keep the canonical list in sync.
-IPC_SYNC_MESSAGE_CONTROL1_0(UtilityHostMsg_LoadPluginFailed,
+IPC_SYNC_MESSAGE_CONTROL2_0(UtilityHostMsg_LoadPluginFailed,
+ size_t /* index in the vector */,
jam 2011/11/02 16:09:29 here and below, it's slightly better to send int i
Bernhard Bauer 2011/11/02 16:13:47 Oooh. Out of curiosity, what would be necessary to
Robert Sesek 2011/11/02 16:26:28 Done. Used uint32_t because I'm comparing against
FilePath /* path of plugin */)
// Notifies the browser that a plugin in the vector sent by it has been loaded.
-IPC_SYNC_MESSAGE_CONTROL1_0(UtilityHostMsg_LoadedPlugin,
+IPC_SYNC_MESSAGE_CONTROL2_0(UtilityHostMsg_LoadedPlugin,
+ size_t /* index in the vector */,
webkit::WebPluginInfo /* plugin info */)
#endif // OS_POSIX

Powered by Google App Engine
This is Rietveld 408576698