Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 8440003: Revert 108116 - Use GYP to build nacl_irt (Closed)

Created:
9 years, 1 month ago by dmichael (off chromium)
Modified:
9 years, 1 month ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 108116 - Use GYP to build nacl_irt Converts Chrome from using scons to using GYP when building nacl_irt. This change causes chrome to use GYP based components for untrusted code. As a benifit, GYP will no longer need to run and scrape scons output to determine irt dependencies. This also allows us to avoid invoking scons during the build process. We roll NaCl deps to get a fix for a simultaneous 32/64 bit build issue on Windows. TEST= try BUG= http://code.google.com/p/chromium/issues/detail?id=96782 Review URL: http://codereview.chromium.org/8416025 TBR=noelallen@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108119

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -238 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M build/scan_sources.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/nacl.gypi View 3 chunks +74 lines, -11 lines 0 comments Download
D ppapi/native_client/native_client.gyp View 1 chunk +0 lines, -62 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/ppapi_proxy.gyp View 1 chunk +0 lines, -91 lines 0 comments Download
M ppapi/ppapi_tests.gypi View 1 chunk +0 lines, -72 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
dmichael (off chromium)
9 years, 1 month ago (2011-11-01 17:03:47 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698