Tweaks to get presubmit working

tools/presubmit.sh

Index: tools/presubmit.sh
diff --git a/tools/presubmit.sh b/tools/presubmit.sh
index da0fadaf158c2893bf2d40f736cef2ef91c9efbc..fb5d07bb2b158fb68ec8966c1a41b07a4cf831b5 100755
--- a/tools/presubmit.sh
+++ b/tools/presubmit.sh
@@ -45,7 +45,7 @@ function doBuild {
 # $3 mode
 # Returns the output from the subcommand
 function doTest {
-  ./tools/test.py --arch $2 --mode $3
+  ./tools/test.py --$2 $3 --mode $4
   RESULT=$?
   if [ ${RESULT} != 0 ] ; then
     TESTS_FAILED=1
@@ -95,11 +95,11 @@ doBuild ia32 debug
 echo
 echo "=== Runtime tests === "
 echo " Debug (Ctrl-C to skip this set of tests)"
-doTest runtime ia32 debug
+doTest runtime arch ia32 debug

[zundel, 2011/11/01 18:13:47]

this doesn't seem right.  the component in this case is named "vm", then we can
either nail up the --arch parameter to ia32 inside of doTest, or omit it
entirely (that's what I'd prefer)

[codefu, 2011/11/01 18:15:14]

I like that better than specifying the component on each line.

 RUNTIME_RESULT=$?
 if [ ${RUNTIME_RESULT} == 0 ] ; then
   echo " Release (Ctrl-C to skip this set of tests)"
-  doTest runtime ia32 release 
+  doTest runtime arch ia32 release 
   RUNTIME_RESULT=$?
 fi
 
@@ -107,12 +107,12 @@ fi
 echo
 echo "=== Compiler tests ==="
 echo " Debug mode (Ctrl-C to skip this set of tests)"
-doTest compiler dartc debug
+doTest compiler component dartc debug
 COMPILER_RESULT=$?
 
 if [ ${DO_OPTIMIZE} == 1 ] ; then
   echo " Release mode (--optimize)"
-  doTest compiler dartc release
+  doTest compiler component dartc release
   RESULT=$?
   if [ ${RESULT} != 0 ] ; then
     COMPILER_RESULT=${RESULT}
@@ -122,12 +122,12 @@ fi
 echo
 echo "=== Client tests ==="
 echo " Chromium  (Ctrl-C to skip this set of tests)"
-doTest client chromium debug
+doTest client component chromium debug
 CLIENT_RESULT=$?
 
 if [ ${DO_OPTIMIZE} == 1 ] ; then
   echo " Chromium Release mode (--optimize)"
-  doTest compiler chromium release
+  doTest compiler component chromium release
   RESULT=$?
   if [ ${RESULT} != 0 ] ; then
     CLIENT_RESULT=${RESULT}
@@ -136,7 +136,7 @@ fi
 
 if [ ${DO_DARTIUM} == 1 ] ; then
   echo " Dartium (Ctrl-C to skip this set of tests)"
-  doTest client dartium release
+  doTest client component dartium release
   RESULT=$?
   if [ ${RESULT} != 0 ] ; then
     CLIENT_RESULT=${RESULT}