Tweaks to get presubmit working

tools/presubmit.sh

 #!/bin/bash
 #
 # Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 #
 
 # A quick check over a subset the tests in the runtime, compiler 
 # and client directories.
 
@@ skipping 27 matching lines @@
     exit 1
   fi
 }
 
 # Execute a set of tests
 # $1 directory to test in
 # $2 arch 
 # $3 mode
 # Returns the output from the subcommand
 function doTest {
-  ./tools/test.py --arch $2 --mode $3
+  ./tools/test.py --$2 $3 --mode $4
   RESULT=$?
   if [ ${RESULT} != 0 ] ; then
     TESTS_FAILED=1
   fi
   return ${RESULT}
 }
 
 # Main
 
 while [ ! -z "$1" ] ; do
@@ skipping 29 matching lines @@
 
 echo
 echo "--- Building debug ---"
 doBuild ia32 debug
 
 
 
 echo
 echo "=== Runtime tests === "
 echo " Debug (Ctrl-C to skip this set of tests)"
-doTest runtime ia32 debug
+doTest runtime arch ia32 debug

[zundel, 2011/11/01 18:13:47]

this doesn't seem right.  the component in this case is named "vm", then we can
either nail up the --arch parameter to ia32 inside of doTest, or omit it
entirely (that's what I'd prefer)

[codefu, 2011/11/01 18:15:14]

I like that better than specifying the component on each line.

 RUNTIME_RESULT=$?
 if [ ${RUNTIME_RESULT} == 0 ] ; then
   echo " Release (Ctrl-C to skip this set of tests)"
-  doTest runtime ia32 release 
+  doTest runtime arch ia32 release 
   RUNTIME_RESULT=$?
 fi
 
 
 echo
 echo "=== Compiler tests ==="
 echo " Debug mode (Ctrl-C to skip this set of tests)"
-doTest compiler dartc debug
+doTest compiler component dartc debug
 COMPILER_RESULT=$?
 
 if [ ${DO_OPTIMIZE} == 1 ] ; then
   echo " Release mode (--optimize)"
-  doTest compiler dartc release
+  doTest compiler component dartc release
   RESULT=$?
   if [ ${RESULT} != 0 ] ; then
     COMPILER_RESULT=${RESULT}
   fi
 fi
 
 echo
 echo "=== Client tests ==="
 echo " Chromium  (Ctrl-C to skip this set of tests)"
-doTest client chromium debug
+doTest client component chromium debug
 CLIENT_RESULT=$?
 
 if [ ${DO_OPTIMIZE} == 1 ] ; then
   echo " Chromium Release mode (--optimize)"
-  doTest compiler chromium release
+  doTest compiler component chromium release
   RESULT=$?
   if [ ${RESULT} != 0 ] ; then
     CLIENT_RESULT=${RESULT}
   fi
 fi
 
 if [ ${DO_DARTIUM} == 1 ] ; then
   echo " Dartium (Ctrl-C to skip this set of tests)"
-  doTest client dartium release
+  doTest client component dartium release
   RESULT=$?
   if [ ${RESULT} != 0 ] ; then
     CLIENT_RESULT=${RESULT}
   fi
 fi
 
 # Print summary of results
 if [ ${RUNTIME_RESULT}  != 0 ] ; then
   echo "*** Runtime tests failed"
 fi
 
 if [ ${COMPILER_RESULT}  != 0 ] ; then
   echo "*** Compiler tests failed"
 fi
 
 if [ ${CLIENT_RESULT}  != 0 ] ; then
   echo "*** Client tests failed"
 fi
 
 if [ ${TESTS_FAILED} == 0 ] ; then
   echo "All presubmit tests passed!"
 fi