Revert 108214 - Try to fix a renderer crash.

Revert 108214 - Try to fix a renderer crash.

WebRange::fromDocumentRange() can return a null range. I don't
know when this happens in practice, but there are crash reports
for it.

BUG=100884
TEST=none


Review URL: http://codereview.chromium.org/8423022

TBR=thakis@chromium.org
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108268

[Nico, 2011-11-02 15:02:14]

When reverting changes, please always say why you reverted in the CL description
of the revert. I have no idea why this was reverted, so the only way to fix for
me is to reland and see what breaks.

[glotov, 2011-11-02 15:17:53]

Hi!

Sorry for false revert of your change. You were in the Blamelist of
http://build.chromium.org/p/chromium/builders/Vista%20Tests%20%28dbg%29%284%2...
and your change looked similar with the failing test from the stranger
point of view.
I reverted my revert @108294.


On Wed, Nov 2, 2011 at 7:02 PM,  <thakis@chromium.org> wrote:
> When reverting changes, please always say why you reverted in the CL
> description
> of the revert. I have no idea why this was reverted, so the only way to fix
> for
> me is to reland and see what breaks.
>
> http://codereview.chromium.org/8438035/
>



-- 
Thank you,
Denis

[Nico, 2011-11-02 15:24:43]

On 2011/11/02 15:17:53, glotov wrote:
> Sorry for false revert of your change. You were in the Blamelist of
>
http://build.chromium.org/p/chromium/builders/Vista%2520Tests%2520%2528dbg%25...
> and your change looked similar with the failing test from the stranger
> point of view.
> I reverted my revert @108294.

Thanks!

Note that I'm not at all complaining that you reverted this CL. Next time, just
add "Speculative revert, trying to fix
http://build.chromium.org/p/chromium/builders/Vista%2520Tests%2520%2528dbg%25...
to the CL description, so that I know a) what the revert is for b) that it's
speculative and possibly not the cause.

[glotov, 2011-11-02 15:28:20]

Good point.
Worth updating
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium?

On Wed, Nov 2, 2011 at 7:24 PM,  <thakis@chromium.org> wrote:
> On 2011/11/02 15:17:53, glotov wrote:
>>
>> Sorry for false revert of your change. You were in the Blamelist of
>
>
http://build.chromium.org/p/chromium/builders/Vista%2520Tests%2520%2528dbg%25...
>>
>> and your change looked similar with the failing test from the stranger
>> point of view.
>> I reverted my revert @108294.
>
> Thanks!
>
> Note that I'm not at all complaining that you reverted this CL. Next time,
> just
> add "Speculative revert, trying to fix
>
http://build.chromium.org/p/chromium/builders/Vista%2520Tests%2520%2528dbg%25...
> to the CL description, so that I know a) what the revert is for b) that it's
> speculative and possibly not the cause.
>
> http://codereview.chromium.org/8438035/
>



-- 
Thank you,
Denis