Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 8423022: Try to fix a renderer crash. (Closed)

Created:
9 years, 1 month ago by Nico
Modified:
9 years, 1 month ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dpranke-watch+content_chromium.org
Visibility:
Public.

Description

Try to fix a renderer crash. WebRange::fromDocumentRange() can return a null range. I don't know when this happens in practice, but there are crash reports for it. BUG=100884 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108214

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M content/renderer/render_view_impl.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
(unused - use chromium)
9 years, 1 month ago (2011-11-01 21:31:22 UTC) #1
Nico
9 years, 1 month ago (2011-11-01 21:32:34 UTC) #2
darin (slow to review)
LGTM
9 years, 1 month ago (2011-11-01 23:27:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/8423022/1
9 years, 1 month ago (2011-11-01 23:44:22 UTC) #4
commit-bot: I haz the power
9 years, 1 month ago (2011-11-02 00:54:03 UTC) #5
Change committed as 108214

Powered by Google App Engine
This is Rietveld 408576698