base/test/signaling_task.h - Issue 8438034: Moving the SignalingTask class to base/test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/test/signaling_task.h

Issue 8438034: Moving the SignalingTask class to base/test. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/test/signaling_task.h

===================================================================

--- base/test/signaling_task.h (working copy)

+++ base/test/signaling_task.h (working copy)

@@ -12,7 +12,6 @@

namespace base {

Paweł Hajdan Jr. 2011/11/02 10:47:02 nit: An empty line below then please.

tommi (sloooow) - chröme 2011/11/02 11:28:37 Done.

class WaitableEvent;

class SignalingTask : public Task {

public:

@@ -24,5 +23,6 @@

private:

base::WaitableEvent* event_;

Paweł Hajdan Jr. 2011/11/02 10:47:02 nit: DISALLOW_COPY_AND_ASSIGN, not sure why it was

};

+} // namespace base

Paweł Hajdan Jr. 2011/11/02 10:47:02 nit: Same here, add an empty line above.

tommi (sloooow) - chröme 2011/11/02 11:28:37 Done.

#endif // CHROME_TEST_BASE_SIGNALING_TASK_H_

« no previous file with comments | « base/base.gyp ('k') | base/test/signaling_task.cc » ('j') | no next file with comments »