Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Side by Side Diff: base/test/signaling_task.h

Issue 8438034: Moving the SignalingTask class to base/test. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « base/base.gyp ('k') | base/test/signaling_task.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // A simple callback that you can use to wait for events on a thread. 5 // A simple callback that you can use to wait for events on a thread.
6 6
7 #ifndef CHROME_TEST_BASE_SIGNALING_TASK_H_ 7 #ifndef CHROME_TEST_BASE_SIGNALING_TASK_H_
Paweł Hajdan Jr. 2011/11/02 10:47:02 nit: Update the header guards.
tommi (sloooow) - chröme 2011/11/02 11:28:37 Done.
8 #define CHROME_TEST_BASE_SIGNALING_TASK_H_ 8 #define CHROME_TEST_BASE_SIGNALING_TASK_H_
9 #pragma once 9 #pragma once
10 10
11 #include "base/task.h" 11 #include "base/task.h"
12 12
13 namespace base { 13 namespace base {
Paweł Hajdan Jr. 2011/11/02 10:47:02 nit: An empty line below then please.
tommi (sloooow) - chröme 2011/11/02 11:28:37 Done.
14 class WaitableEvent; 14 class WaitableEvent;
15 }
16 15
17 class SignalingTask : public Task { 16 class SignalingTask : public Task {
18 public: 17 public:
19 explicit SignalingTask(base::WaitableEvent* event); 18 explicit SignalingTask(base::WaitableEvent* event);
20 virtual ~SignalingTask(); 19 virtual ~SignalingTask();
21 20
22 virtual void Run(); 21 virtual void Run();
23 22
24 private: 23 private:
25 base::WaitableEvent* event_; 24 base::WaitableEvent* event_;
Paweł Hajdan Jr. 2011/11/02 10:47:02 nit: DISALLOW_COPY_AND_ASSIGN, not sure why it was
26 }; 25 };
26 } // namespace base
Paweł Hajdan Jr. 2011/11/02 10:47:02 nit: Same here, add an empty line above.
tommi (sloooow) - chröme 2011/11/02 11:28:37 Done.
27 27
28 #endif // CHROME_TEST_BASE_SIGNALING_TASK_H_ 28 #endif // CHROME_TEST_BASE_SIGNALING_TASK_H_
OLDNEW
« no previous file with comments | « base/base.gyp ('k') | base/test/signaling_task.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698