Issue 8438034: Moving the SignalingTask class to base/test.

Issue 8438034: Moving the SignalingTask class to base/test. (Closed)

Created:
9 years, 1 month ago by tommi (sloooow) - chröme

Modified:
9 years, 1 month ago

Reviewers:
Paweł Hajdan Jr.

CC:
chromium-reviews, ncarter (slow), akalin, Raghu Simha, Erik does not do reviews, brettw-cc_chromium.org, cbentzel+watch_chromium.org, mihaip+watch_chromium.org, Aaron Boodman, darin-cc_chromium.org, Paweł Hajdan Jr., tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Moving the SignalingTask class to base/test. As requested in another review (http://codereview.chromium.org/8427031/diff/1009/content/renderer/media/webrtc_audio_device_unittest.cc#newcode132). so that it can be reused in content tests. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108271

Patch Set 1 #

Total comments: 7

Patch Set 2 : Addressed comments #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -85 lines)			Patch
M	base/base.gyp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A +	base/test/signaling_task.h	View	1	2 chunks	+7 lines, -4 lines	0 comments	Download
A +	base/test/signaling_task.cc	View		2 chunks	+5 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/test_extension_prefs.cc	View		3 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/net/gaia/token_service_unittest.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/net/gaia/token_service_unittest.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/password_manager/password_store_default_unittest.cc	View		11 chunks	+10 lines, -10 lines	0 comments	Download
M	chrome/browser/password_manager/password_store_win_unittest.cc	View		8 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/browser/password_manager/password_store_x_unittest.cc	View		13 chunks	+12 lines, -12 lines	0 comments	Download
M	chrome/browser/sync/signin_manager_unittest.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/chrome_tests.gypi	View		1 chunk	+0 lines, -2 lines	0 comments	Download
D	chrome/test/base/signaling_task.h	View		1 chunk	+0 lines, -28 lines	0 comments	Download
D	chrome/test/base/signaling_task.cc	View		1 chunk	+0 lines, -16 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

LGTM with nits. http://codereview.chromium.org/8438034/diff/1/base/test/signaling_task.h File base/test/signaling_task.h (right): http://codereview.chromium.org/8438034/diff/1/base/test/signaling_task.h#newcode7 base/test/signaling_task.h:7: #ifndef CHROME_TEST_BASE_SIGNALING_TASK_H_ nit: Update the header ...

9 years, 1 month ago (2011-11-02 10:47:01 UTC) #2

tommi (sloooow) - chröme

9 years, 1 month ago (2011-11-02 11:28:37 UTC) #3

http://codereview.chromium.org/8438034/diff/1/base/test/signaling_task.h
File base/test/signaling_task.h (right):

http://codereview.chromium.org/8438034/diff/1/base/test/signaling_task.h#newc...
base/test/signaling_task.h:7: #ifndef CHROME_TEST_BASE_SIGNALING_TASK_H_
On 2011/11/02 10:47:02, Paweł Hajdan Jr. wrote:
> nit: Update the header guards.

Done.

http://codereview.chromium.org/8438034/diff/1/base/test/signaling_task.h#newc...
base/test/signaling_task.h:13: namespace base {
On 2011/11/02 10:47:02, Paweł Hajdan Jr. wrote:
> nit: An empty line below then please.

Done.

http://codereview.chromium.org/8438034/diff/1/base/test/signaling_task.h#newc...
base/test/signaling_task.h:26: }  // namespace base
On 2011/11/02 10:47:02, Paweł Hajdan Jr. wrote:
> nit: Same here, add an empty line above.

Done.

Expand Messages | Collapse Messages