Remove dcheck at CrxInstaller teardown

Remove dcheck at CrxInstaller teardown

dchecks because it tries to post a task to the file thread, but chrome is shutting down so post fails

This makes startup tests flaky.

BUG=none
TEST=startup tests do not crash, ask nsylvain.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108213

[asargent_no_longer_on_chrome, 2011-11-01 22:15:01]

LGTM

http://codereview.chromium.org/8438017/diff/1/chrome/browser/extensions/crx_i...
File chrome/browser/extensions/crx_installer.cc (right):

http://codereview.chromium.org/8438017/diff/1/chrome/browser/extensions/crx_i...
chrome/browser/extensions/crx_installer.cc:141: // be a file thread to post to.
would it make sense to do something like this?


if (!BrowserThread::PostTask(.....)) {
  ...
  if (!g_browser_process->IsShuttingDown())
    NOTREACHED()
}

[commit-bot: I haz the power, 2011-11-01 23:26:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/cpu@chromium.org/8438017/1

[cpu_(ooo_6.6-7.5), 2011-11-01 23:29:18]

On 2011/11/01 22:15:01, Antony Sargent wrote:
> LGTM
> 
>
http://codereview.chromium.org/8438017/diff/1/chrome/browser/extensions/crx_i...
> File chrome/browser/extensions/crx_installer.cc (right):
> 
>
http://codereview.chromium.org/8438017/diff/1/chrome/browser/extensions/crx_i...
> chrome/browser/extensions/crx_installer.cc:141: // be a file thread to post
to.
> would it make sense to do something like this?
> 
> 
> if (!BrowserThread::PostTask(.....)) {
>   ...
>   if (!g_browser_process->IsShuttingDown())
>     NOTREACHED()
>

I think this is something we can add to BrowserThread so we don't have to
sprinkle this test + check everywhere.

[asargent_no_longer_on_chrome, 2011-11-01 23:48:58]

SGTM

On Tue, Nov 1, 2011 at 4:29 PM, <cpu@chromium.org> wrote:

> On 2011/11/01 22:15:01, Antony Sargent wrote:
>
>> LGTM
>>
>
>
> http://codereview.chromium.**org/8438017/diff/1/chrome/**
>
browser/extensions/crx_**installer.cc<http://codereview.chromium.org/8438017/diff/1/chrome/browser/extensions/crx_installer.cc>
>
>> File chrome/browser/extensions/crx_**installer.cc (right):
>>
>
>
> http://codereview.chromium.**org/8438017/diff/1/chrome/**
>
browser/extensions/crx_**installer.cc#newcode141<http://codereview.chromium.org/8438017/diff/1/chrome/browser/extensions/crx_installer.cc#newcode141>
>
>> chrome/browser/extensions/crx_**installer.cc:141: // be a file thread to
>> post
>>
> to.
>
>> would it make sense to do something like this?
>>
>
>
>  if (!BrowserThread::PostTask(....**.)) {
>>   ...
>>   if (!g_browser_process->**IsShuttingDown())
>>     NOTREACHED()
>>
>
>
> I think this is something we can add to BrowserThread so we don't have to
> sprinkle this test + check everywhere.
>
>
>
>
http://codereview.chromium.**org/8438017/<http://codereview.chromium.org/8438...
>

[commit-bot: I haz the power, 2011-11-02 00:42:14]

Change committed as 108213