Remove dcheck at CrxInstaller teardown

chrome/browser/extensions/crx_installer.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/crx_installer.h"
 
 #include <map>
 #include <set>
 
 #include "base/bind.h"
@@ skipping 118 matching lines @@
       client_(client),
       apps_require_extension_mime_type_(false),
       allow_silent_install_(false),
       install_cause_(extension_misc::INSTALL_CAUSE_UNSET),
       creation_flags_(Extension::NO_FLAGS) {
 }
 
 CrxInstaller::~CrxInstaller() {
   // Delete the temp directory and crx file as necessary. Note that the
   // destructor might be called on any thread, so we post a task to the file
-  // thread to make sure the delete happens there.
+  // thread to make sure the delete happens there. This is a best effort
+  // operation since the browser can be shutting down so there might not
+  // be a file thread to post to.

[asargent_no_longer_on_chrome, 2011/11/01 22:15:01]

would it make sense to do something like this?


if (!BrowserThread::PostTask(.....)) {
  ...
  if (!g_browser_process->IsShuttingDown())
    NOTREACHED()
}

   if (!temp_dir_.value().empty()) {
-    if (!BrowserThread::PostTask(
-            BrowserThread::FILE, FROM_HERE,
-            base::Bind(
-                &extension_file_util::DeleteFile, temp_dir_, true)))
-      NOTREACHED();
+    BrowserThread::PostTask(BrowserThread::FILE, FROM_HERE,
+        base::Bind(&extension_file_util::DeleteFile, temp_dir_, true));
   }
-
   if (delete_source_) {
-    if (!BrowserThread::PostTask(
-            BrowserThread::FILE, FROM_HERE,
-            base::Bind(
-                &extension_file_util::DeleteFile, source_file_, false)))
-      NOTREACHED();
+    BrowserThread::PostTask(BrowserThread::FILE, FROM_HERE,
+        base::Bind(&extension_file_util::DeleteFile, source_file_, false));
   }
-
   // Make sure the UI is deleted on the ui thread.
   BrowserThread::DeleteSoon(BrowserThread::UI, FROM_HERE, client_);
   client_ = NULL;
 }
 
 void CrxInstaller::InstallCrx(const FilePath& source_file) {
   source_file_ = source_file;
 
   scoped_refptr<SandboxedExtensionUnpacker> unpacker(
       new SandboxedExtensionUnpacker(
@@ skipping 430 matching lines @@
   // Some users (such as the download shelf) need to know when a
   // CRXInstaller is done.  Listening for the EXTENSION_* events
   // is problematic because they don't know anything about the
   // extension before it is unpacked, so they can not filter based
   // on the extension.
   content::NotificationService::current()->Notify(
       chrome::NOTIFICATION_CRX_INSTALLER_DONE,
       content::Source<CrxInstaller>(this),
       content::NotificationService::NoDetails());
 }