Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 8437034: Roll UPSTREAM_REV and make other changes needed to bring in CL: (Closed)

Created:
9 years, 1 month ago by pdox
Modified:
9 years, 1 month ago
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

* Roll UPSTREAM_REV to bring in CL: http://codereview.chromium.org/8439026 * Get rid of "-barebones-link" flag. (This is no longer needed after removing symbol preservation hacks) * Add __nacl_read_tp to crt1.x so that it gets preserved by the bitcode link and is available in the final output object (it is in the bitcode libnacl, but calls to it are generated by llc) BUG= http://code.google.com/p/nativeclient/issues/detail?id=1520 Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=7097

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -12 lines) Patch
M pnacl/build.sh View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M pnacl/driver/pnacl-driver.py View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M pnacl/driver/pnacl-ld.py View 1 2 3 4 4 chunks +1 line, -9 lines 0 comments Download
M pnacl/support/crt1.x View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
pdox
9 years, 1 month ago (2011-11-02 01:22:29 UTC) #1
robertm
I see a of misc changes here that do not seem to be related to ...
9 years, 1 month ago (2011-11-02 14:01:35 UTC) #2
pdox
robert, added description.
9 years, 1 month ago (2011-11-02 16:02:35 UTC) #3
(google.com) Derek Schuff
On 2011/11/02 16:02:35, pdox wrote: > robert, added description. LGTM
9 years, 1 month ago (2011-11-02 16:23:14 UTC) #4
(google.com) Derek Schuff
well LGTM once the the other commit has landed, obviously On Wed, Nov 2, 2011 ...
9 years, 1 month ago (2011-11-02 16:24:05 UTC) #5
robertm
9 years, 1 month ago (2011-11-02 17:38:41 UTC) #6
LGTM

it would be good to cross link this with http://codereview.chromium.org/8439026/

Since it is also undoing stuff from 
http://code.google.com/p/nativeclient/issues/detail?id=1520
this bug should be referenced
On 2011/11/02 16:24:05, Derek Schuff wrote:
> well LGTM once the the other commit has landed, obviously
> 
> On Wed, Nov 2, 2011 at 9:23 AM, <mailto:dschuff@google.com> wrote:
> 
> > On 2011/11/02 16:02:35, pdox wrote:
> >
> >> robert, added description.
> >>
> >
> > LGTM
> >
> >
>
http://codereview.chromium.**org/8437034/%3Chttp://codereview.chromium.org/84...>
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Native-Client-Reviews" group.
> To post to this group, send email to
mailto:native-client-reviews@googlegroups.com.
> To unsubscribe from this group, send email to
> mailto:native-client-reviews+unsubscribe@googlegroups.com.
> For more options, visit this group at
> http://groups.google.com/group/native-client-reviews?hl=en.
>

Powered by Google App Engine
This is Rietveld 408576698