[cros] Remove Views implementation for login/OOBE.

[cros] Remove Views implementation for login/OOBE.

Left few Views classes that are used in ScreenLockView.
Left --webui-login flag (need a separate cleanup for login auth).
Left registration/html page screen (will address separately).

BUG=99545
TEST=WebUI login/OOBE should work fine.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109233

[Nikita (slow), 2011-11-01 14:54:22]

Please take a look.

52 files changed, 26 insertions(+), 6801 deletions(-)

[Nikita (slow), 2011-11-01 16:51:52]

altimofeev: OOBE/login Views implementation classes deletion.
mnissler: Enrollment Views/Obsolete WebuUI (non-OAuth) implementation classes
deletion.

[Mattias Nissler (ping if slow), 2011-11-02 11:00:20]

enterprise enrollment stuff LGTM if/after you made sure we don't leave any
unused enrollment strings.

http://codereview.chromium.org/8436002/diff/3002/chrome/browser/browser_resou...
File chrome/browser/browser_resources.grd (left):

http://codereview.chromium.org/8436002/diff/3002/chrome/browser/browser_resou...
chrome/browser/browser_resources.grd:134: <include
name="IDR_ENTERPRISE_ENROLLMENT_HTML" file="policy\resources\enrollment.html"
flattenhtml="true" type="BINDATA" />
There might also be a few strings that are used only in the old UI.

[Nikita (slow), 2011-11-02 12:45:35]

I'm dealing with tests that started failing with removal of views
implementations.

EnterpriseMetricsEnrollmentTest.EnrollmentOK is one of them.

http://codereview.chromium.org/8436002/diff/3002/chrome/browser/browser_resou...
File chrome/browser/browser_resources.grd (left):

http://codereview.chromium.org/8436002/diff/3002/chrome/browser/browser_resou...
chrome/browser/browser_resources.grd:134: <include
name="IDR_ENTERPRISE_ENROLLMENT_HTML" file="policy\resources\enrollment.html"
flattenhtml="true" type="BINDATA" />
On 2011/11/02 11:00:20, Mattias Nissler wrote:
> There might also be a few strings that are used only in the old UI.

Ok, I'll do a pass through those strings.

[Nikita (slow), 2011-11-02 15:11:15]

http://codereview.chromium.org/8436002/diff/3002/chrome/browser/browser_resou...
File chrome/browser/browser_resources.grd (left):

http://codereview.chromium.org/8436002/diff/3002/chrome/browser/browser_resou...
chrome/browser/browser_resources.grd:134: <include
name="IDR_ENTERPRISE_ENROLLMENT_HTML" file="policy\resources\enrollment.html"
flattenhtml="true" type="BINDATA" />
On 2011/11/02 11:00:20, Mattias Nissler wrote:
> There might also be a few strings that are used only in the old UI.

Done.

[Nikita (slow), 2011-11-07 09:40:18]

One test that I haven't fixed yet is
EnterpriseMetricsEnrollmentTest.EnrollmentOK.

Since this test now uses OAuth version of enrollment flow it includes call to
ClearBrowsingData which opens an IPC channel to clear up Plugin data. This
channel is not closed by the time test finishes.
ui_test_utils::RunAllPendingInMessageLoop() or using the solution from
PluginServiceTest (post task from IO thread to FILE thread) didn't help. I think
that's the difference on how we operate MessageLoop in tests that are instance
of WizardInProcessBrowserTest.

[Mattias Nissler (ping if slow), 2011-11-07 09:43:46]

+joaodasilva for EnterpriseMetricsEnrollmentTest

On Mon, Nov 7, 2011 at 10:40 AM, <nkostylev@chromium.org> wrote:

> One test that I haven't fixed yet is
> EnterpriseMetricsEnrollmentTes**t.EnrollmentOK.
>
> Since this test now uses OAuth version of enrollment flow it includes call
> to
> ClearBrowsingData which opens an IPC channel to clear up Plugin data. This
> channel is not closed by the time test finishes.
> ui_test_utils::**RunAllPendingInMessageLoop() or using the solution from
> PluginServiceTest (post task from IO thread to FILE thread) didn't help. I
> think
> that's the difference on how we operate MessageLoop in tests that are
> instance
> of WizardInProcessBrowserTest.
>
>
http://codereview.chromium.**org/8436002/<http://codereview.chromium.org/8436...
>

[altimofeev, 2011-11-07 11:07:09]

LGTM,
also you can painlessly remove "rounded_view.h" file.

http://codereview.chromium.org/8436002/diff/11001/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/base_login_display_host.cc (right):

http://codereview.chromium.org/8436002/diff/11001/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/base_login_display_host.cc:249: #if
defined(USE_AURA)
nit: this if-else is not needed anymore

http://codereview.chromium.org/8436002/diff/11001/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/network_screen_browsertest.cc (left):

http://codereview.chromium.org/8436002/diff/11001/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/network_screen_browsertest.cc:129: //
TODO(avayvod): Refactor this when WebUI implementation is finished.
nit: also add TODO please

http://codereview.chromium.org/8436002/diff/11001/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/wizard_controller_browsertest.cc (right):

http://codereview.chromium.org/8436002/diff/11001/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/wizard_controller_browsertest.cc:249:
/*IN_PROC_BROWSER_TEST_F(WizardControllerFlowTest, MAYBE_Accelerators) {
nit: add TODO please

[Nikita (slow), 2011-11-07 11:27:43]

http://codereview.chromium.org/8436002/diff/11001/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/base_login_display_host.cc (right):

http://codereview.chromium.org/8436002/diff/11001/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/base_login_display_host.cc:249: #if
defined(USE_AURA)
On 2011/11/07 11:07:09, altimofeev wrote:
> nit: this if-else is not needed anymore

Done.

http://codereview.chromium.org/8436002/diff/11001/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/network_screen_browsertest.cc (left):

http://codereview.chromium.org/8436002/diff/11001/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/network_screen_browsertest.cc:129: //
TODO(avayvod): Refactor this when WebUI implementation is finished.
On 2011/11/07 11:07:09, altimofeev wrote:
> nit: also add TODO please

Done.

http://codereview.chromium.org/8436002/diff/11001/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/wizard_controller_browsertest.cc (right):

http://codereview.chromium.org/8436002/diff/11001/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/wizard_controller_browsertest.cc:249:
/*IN_PROC_BROWSER_TEST_F(WizardControllerFlowTest, MAYBE_Accelerators) {
On 2011/11/07 11:07:09, altimofeev wrote:
> nit: add TODO please

Done.