Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Side by Side Diff: chrome/browser/chromeos/login/network_screen_browsertest.cc

Issue 8436002: [cros] Remove Views implementation for login/OOBE. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merge Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 6
7 #include "base/memory/scoped_ptr.h" 7 #include "base/memory/scoped_ptr.h"
8 #include "base/message_loop.h" 8 #include "base/message_loop.h"
9 #include "base/string16.h" 9 #include "base/string16.h"
10 #include "base/string_number_conversions.h" 10 #include "base/string_number_conversions.h"
11 #include "base/utf_string_conversions.h" 11 #include "base/utf_string_conversions.h"
12 #include "chrome/browser/chromeos/cros/cros_library.h" 12 #include "chrome/browser/chromeos/cros/cros_library.h"
13 #include "chrome/browser/chromeos/dbus/mock_dbus_thread_manager.h" 13 #include "chrome/browser/chromeos/dbus/mock_dbus_thread_manager.h"
14 #include "chrome/browser/chromeos/dbus/mock_session_manager_client.h" 14 #include "chrome/browser/chromeos/dbus/mock_session_manager_client.h"
15 #include "chrome/browser/chromeos/cros/mock_network_library.h" 15 #include "chrome/browser/chromeos/cros/mock_network_library.h"
16 #include "chrome/browser/chromeos/cros/network_library.h" 16 #include "chrome/browser/chromeos/cros/network_library.h"
17 #include "chrome/browser/chromeos/login/mock_screen_observer.h" 17 #include "chrome/browser/chromeos/login/mock_screen_observer.h"
18 #include "chrome/browser/chromeos/login/network_screen.h" 18 #include "chrome/browser/chromeos/login/network_screen.h"
19 #include "chrome/browser/chromeos/login/network_selection_view.h"
20 #include "chrome/browser/chromeos/login/view_screen.h" 19 #include "chrome/browser/chromeos/login/view_screen.h"
21 #include "chrome/browser/chromeos/login/views_network_screen_actor.h"
22 #include "chrome/browser/chromeos/login/wizard_controller.h" 20 #include "chrome/browser/chromeos/login/wizard_controller.h"
23 #include "chrome/browser/chromeos/login/wizard_in_process_browser_test.h" 21 #include "chrome/browser/chromeos/login/wizard_in_process_browser_test.h"
24 #include "chrome/browser/chromeos/login/wizard_screen.h" 22 #include "chrome/browser/chromeos/login/wizard_screen.h"
25 #include "chrome/test/base/ui_test_utils.h" 23 #include "chrome/test/base/ui_test_utils.h"
26 #include "grit/generated_resources.h" 24 #include "grit/generated_resources.h"
27 #include "testing/gmock/include/gmock/gmock.h" 25 #include "testing/gmock/include/gmock/gmock.h"
28 #include "testing/gtest/include/gtest/gtest.h" 26 #include "testing/gtest/include/gtest/gtest.h"
29 #include "ui/base/l10n/l10n_util.h" 27 #include "ui/base/l10n/l10n_util.h"
30 #include "views/controls/button/text_button.h" 28 #include "views/controls/button/text_button.h"
31 29
(...skipping 29 matching lines...) Expand all
61 mock_dbus_thread_manager->mock_session_manager_client(); 59 mock_dbus_thread_manager->mock_session_manager_client();
62 cellular_.reset(new NetworkDevice("cellular")); 60 cellular_.reset(new NetworkDevice("cellular"));
63 EXPECT_CALL(*mock_session_manager_client, EmitLoginPromptReady()) 61 EXPECT_CALL(*mock_session_manager_client, EmitLoginPromptReady())
64 .Times(1); 62 .Times(1);
65 EXPECT_CALL(*mock_session_manager_client, RetrievePolicy(_)) 63 EXPECT_CALL(*mock_session_manager_client, RetrievePolicy(_))
66 .Times(AnyNumber()); 64 .Times(AnyNumber());
67 65
68 // Minimal set of expectations needed on NetworkScreen initialization. 66 // Minimal set of expectations needed on NetworkScreen initialization.
69 // Status bar expectations are defined with RetiresOnSaturation() so 67 // Status bar expectations are defined with RetiresOnSaturation() so
70 // these mocks will be active once status bar is initialized. 68 // these mocks will be active once status bar is initialized.
71 EXPECT_CALL(*mock_network_library_, ethernet_connected())
72 .Times(2)
73 .WillRepeatedly(Return(false));
74 EXPECT_CALL(*mock_network_library_, ethernet_connecting())
75 .Times(2)
76 .WillRepeatedly(Return(false));
77 EXPECT_CALL(*mock_network_library_, wifi_connected()) 69 EXPECT_CALL(*mock_network_library_, wifi_connected())
78 .Times(1) 70 .Times(1)
79 .WillRepeatedly(Return(false)); 71 .WillRepeatedly(Return(false));
80 EXPECT_CALL(*mock_network_library_, FindWifiDevice()) 72 EXPECT_CALL(*mock_network_library_, FindWifiDevice())
81 .Times(AnyNumber()); 73 .Times(AnyNumber());
82 EXPECT_CALL(*mock_network_library_, FindEthernetDevice()) 74 EXPECT_CALL(*mock_network_library_, FindEthernetDevice())
83 .Times(AnyNumber()); 75 .Times(AnyNumber());
84 76
85 cros_mock_->SetStatusAreaMocksExpectations(); 77 cros_mock_->SetStatusAreaMocksExpectations();
86 78
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
118 .WillRepeatedly((Return(cellular_.get()))); 110 .WillRepeatedly((Return(cellular_.get())));
119 } 111 }
120 112
121 virtual void SetUpOnMainThread() { 113 virtual void SetUpOnMainThread() {
122 mock_screen_observer_.reset(new MockScreenObserver()); 114 mock_screen_observer_.reset(new MockScreenObserver());
123 ASSERT_TRUE(controller() != NULL); 115 ASSERT_TRUE(controller() != NULL);
124 network_screen_ = controller()->GetNetworkScreen(); 116 network_screen_ = controller()->GetNetworkScreen();
125 ASSERT_TRUE(network_screen_ != NULL); 117 ASSERT_TRUE(network_screen_ != NULL);
126 ASSERT_EQ(controller()->current_screen(), network_screen_); 118 ASSERT_EQ(controller()->current_screen(), network_screen_);
127 network_screen_->screen_observer_ = mock_screen_observer_.get(); 119 network_screen_->screen_observer_ = mock_screen_observer_.get();
128 // We need a couple of methods defined only in views version. 120 ASSERT_TRUE(network_screen_->actor() != NULL);
129 // TODO(avayvod): Refactor this when WebUI implementation is finished.
130 actor_ = static_cast<ViewsNetworkScreenActor*>(network_screen_->actor());
131 ASSERT_TRUE(actor_ != NULL);
132 } 121 }
133 122
134 virtual void TearDownInProcessBrowserTestFixture() { 123 virtual void TearDownInProcessBrowserTestFixture() {
135 network_screen_->screen_observer_ = controller(); 124 network_screen_->screen_observer_ = controller();
136 CrosInProcessBrowserTest::TearDownInProcessBrowserTestFixture(); 125 CrosInProcessBrowserTest::TearDownInProcessBrowserTestFixture();
137 DBusThreadManager::Shutdown(); 126 DBusThreadManager::Shutdown();
138 } 127 }
139 128
140 void EmulateContinueButtonExit(NetworkScreen* network_screen) { 129 void EmulateContinueButtonExit(NetworkScreen* network_screen) {
141 EXPECT_CALL(*mock_screen_observer_, 130 EXPECT_CALL(*mock_screen_observer_,
142 OnExit(ScreenObserver::NETWORK_CONNECTED)) 131 OnExit(ScreenObserver::NETWORK_CONNECTED))
143 .Times(1); 132 .Times(1);
144 EXPECT_CALL(*mock_network_library_, Connected()) 133 EXPECT_CALL(*mock_network_library_, Connected())
145 .WillOnce(Return(true)); 134 .WillOnce(Return(true));
146 network_screen->OnContinuePressed(); 135 network_screen->OnContinuePressed();
147 ui_test_utils::RunAllPendingInMessageLoop(); 136 ui_test_utils::RunAllPendingInMessageLoop();
148 } 137 }
149 138
150 scoped_ptr<MockScreenObserver> mock_screen_observer_; 139 scoped_ptr<MockScreenObserver> mock_screen_observer_;
151 MockNetworkLibrary* mock_network_library_; 140 MockNetworkLibrary* mock_network_library_;
152 scoped_ptr<NetworkDevice> cellular_; 141 scoped_ptr<NetworkDevice> cellular_;
153 NetworkScreen* network_screen_; 142 NetworkScreen* network_screen_;
154 ViewsNetworkScreenActor* actor_;
155 143
156 private: 144 private:
157 DISALLOW_COPY_AND_ASSIGN(NetworkScreenTest); 145 DISALLOW_COPY_AND_ASSIGN(NetworkScreenTest);
158 }; 146 };
159 147
160 IN_PROC_BROWSER_TEST_F(NetworkScreenTest, Ethernet) { 148 IN_PROC_BROWSER_TEST_F(NetworkScreenTest, Ethernet) {
161 EXPECT_CALL(*mock_network_library_, ethernet_connected()) 149 EXPECT_CALL(*mock_network_library_, ethernet_connected())
162 .WillOnce((Return(false))); 150 .WillOnce((Return(false)));
163 EXPECT_CALL(*mock_network_library_, wifi_connected()) 151 EXPECT_CALL(*mock_network_library_, wifi_connected())
164 .WillOnce((Return(false))); 152 .WillOnce((Return(false)));
165 EXPECT_CALL(*mock_network_library_, cellular_connected()) 153 EXPECT_CALL(*mock_network_library_, cellular_connected())
166 .WillOnce((Return(false))); 154 .WillOnce((Return(false)));
167 EXPECT_CALL(*mock_network_library_, ethernet_connecting()) 155 EXPECT_CALL(*mock_network_library_, ethernet_connecting())
168 .WillOnce((Return(true))); 156 .WillOnce((Return(true)));
169 EXPECT_FALSE(actor_->IsContinueEnabled()); 157 // EXPECT_FALSE(actor_->IsContinueEnabled());
170 network_screen_->OnNetworkManagerChanged(mock_network_library_); 158 network_screen_->OnNetworkManagerChanged(mock_network_library_);
171 159
172 EXPECT_CALL(*mock_network_library_, ethernet_connected()) 160 EXPECT_CALL(*mock_network_library_, ethernet_connected())
173 .WillOnce(Return(true)); 161 .WillOnce(Return(true));
174 EXPECT_CALL(*mock_network_library_, Connected()) 162 EXPECT_CALL(*mock_network_library_, Connected())
175 .Times(3) 163 .Times(3)
176 .WillRepeatedly(Return(true)); 164 .WillRepeatedly(Return(true));
177 EXPECT_FALSE(actor_->IsContinueEnabled()); 165 // TODO(nkostylev): Add integration with WebUI actor http://crosbug.com/22570
178 EXPECT_FALSE(actor_->IsConnecting()); 166 // EXPECT_FALSE(actor_->IsContinueEnabled());
167 // EXPECT_FALSE(actor_->IsConnecting());
179 network_screen_->OnNetworkManagerChanged(mock_network_library_); 168 network_screen_->OnNetworkManagerChanged(mock_network_library_);
180 169
181 EXPECT_TRUE(actor_->IsContinueEnabled()); 170 // EXPECT_TRUE(actor_->IsContinueEnabled());
182 EmulateContinueButtonExit(network_screen_); 171 EmulateContinueButtonExit(network_screen_);
183 } 172 }
184 173
185 IN_PROC_BROWSER_TEST_F(NetworkScreenTest, Wifi) { 174 IN_PROC_BROWSER_TEST_F(NetworkScreenTest, Wifi) {
186 EXPECT_CALL(*mock_network_library_, ethernet_connected()) 175 EXPECT_CALL(*mock_network_library_, ethernet_connected())
187 .WillOnce((Return(false))); 176 .WillOnce((Return(false)));
188 EXPECT_CALL(*mock_network_library_, wifi_connected()) 177 EXPECT_CALL(*mock_network_library_, wifi_connected())
189 .WillOnce((Return(false))); 178 .WillOnce((Return(false)));
190 EXPECT_CALL(*mock_network_library_, cellular_connected()) 179 EXPECT_CALL(*mock_network_library_, cellular_connected())
191 .WillOnce((Return(false))); 180 .WillOnce((Return(false)));
192 EXPECT_CALL(*mock_network_library_, ethernet_connecting()) 181 EXPECT_CALL(*mock_network_library_, ethernet_connecting())
193 .WillOnce((Return(false))); 182 .WillOnce((Return(false)));
194 EXPECT_CALL(*mock_network_library_, wifi_connecting()) 183 EXPECT_CALL(*mock_network_library_, wifi_connecting())
195 .WillOnce((Return(true))); 184 .WillOnce((Return(true)));
196 scoped_ptr<WifiNetwork> wifi(new WifiNetwork("wifi")); 185 scoped_ptr<WifiNetwork> wifi(new WifiNetwork("wifi"));
197 WifiNetworkVector wifi_networks; 186 WifiNetworkVector wifi_networks;
198 wifi_networks.push_back(wifi.get()); 187 wifi_networks.push_back(wifi.get());
199 EXPECT_CALL(*mock_network_library_, wifi_network()) 188 EXPECT_CALL(*mock_network_library_, wifi_network())
200 .WillRepeatedly(Return(wifi.get())); 189 .WillRepeatedly(Return(wifi.get()));
201 EXPECT_CALL(*mock_network_library_, wifi_networks()) 190 EXPECT_CALL(*mock_network_library_, wifi_networks())
202 .WillRepeatedly(ReturnRef(wifi_networks)); 191 .WillRepeatedly(ReturnRef(wifi_networks));
203 EXPECT_FALSE(actor_->IsContinueEnabled()); 192 // EXPECT_FALSE(actor_->IsContinueEnabled());
204 network_screen_->OnNetworkManagerChanged(mock_network_library_); 193 network_screen_->OnNetworkManagerChanged(mock_network_library_);
205 194
206 EXPECT_CALL(*mock_network_library_, ethernet_connected()) 195 EXPECT_CALL(*mock_network_library_, ethernet_connected())
207 .WillOnce(Return(true)); 196 .WillOnce(Return(true));
208 EXPECT_CALL(*mock_network_library_, Connected()) 197 EXPECT_CALL(*mock_network_library_, Connected())
209 .Times(3) 198 .Times(3)
210 .WillRepeatedly(Return(true)); 199 .WillRepeatedly(Return(true));
211 EXPECT_FALSE(actor_->IsContinueEnabled()); 200 // TODO(nkostylev): Add integration with WebUI actor http://crosbug.com/22570
212 EXPECT_FALSE(actor_->IsConnecting()); 201 // EXPECT_FALSE(actor_->IsContinueEnabled());
202 // EXPECT_FALSE(actor_->IsConnecting());
213 network_screen_->OnNetworkManagerChanged(mock_network_library_); 203 network_screen_->OnNetworkManagerChanged(mock_network_library_);
214 204
215 EXPECT_TRUE(actor_->IsContinueEnabled()); 205 // EXPECT_TRUE(actor_->IsContinueEnabled());
216 EmulateContinueButtonExit(network_screen_); 206 EmulateContinueButtonExit(network_screen_);
217 } 207 }
218 208
219 IN_PROC_BROWSER_TEST_F(NetworkScreenTest, Cellular) { 209 IN_PROC_BROWSER_TEST_F(NetworkScreenTest, Cellular) {
220 EXPECT_CALL(*mock_network_library_, ethernet_connected()) 210 EXPECT_CALL(*mock_network_library_, ethernet_connected())
221 .WillOnce((Return(false))); 211 .WillOnce((Return(false)));
222 EXPECT_CALL(*mock_network_library_, wifi_connected()) 212 EXPECT_CALL(*mock_network_library_, wifi_connected())
223 .WillOnce((Return(false))); 213 .WillOnce((Return(false)));
224 EXPECT_CALL(*mock_network_library_, cellular_connected()) 214 EXPECT_CALL(*mock_network_library_, cellular_connected())
225 .WillOnce((Return(false))); 215 .WillOnce((Return(false)));
226 EXPECT_CALL(*mock_network_library_, ethernet_connecting()) 216 EXPECT_CALL(*mock_network_library_, ethernet_connecting())
227 .WillOnce((Return(false))); 217 .WillOnce((Return(false)));
228 EXPECT_CALL(*mock_network_library_, wifi_connecting()) 218 EXPECT_CALL(*mock_network_library_, wifi_connecting())
229 .WillOnce((Return(false))); 219 .WillOnce((Return(false)));
230 EXPECT_CALL(*mock_network_library_, cellular_connecting()) 220 EXPECT_CALL(*mock_network_library_, cellular_connecting())
231 .WillOnce((Return(true))); 221 .WillOnce((Return(true)));
232 scoped_ptr<CellularNetwork> cellular(new CellularNetwork("cellular")); 222 scoped_ptr<CellularNetwork> cellular(new CellularNetwork("cellular"));
233 EXPECT_CALL(*mock_network_library_, cellular_network()) 223 EXPECT_CALL(*mock_network_library_, cellular_network())
234 .WillOnce(Return(cellular.get())); 224 .WillOnce(Return(cellular.get()));
235 EXPECT_FALSE(actor_->IsContinueEnabled()); 225 // EXPECT_FALSE(actor_->IsContinueEnabled());
236 network_screen_->OnNetworkManagerChanged(mock_network_library_); 226 network_screen_->OnNetworkManagerChanged(mock_network_library_);
237 227
238 EXPECT_CALL(*mock_network_library_, ethernet_connected()) 228 EXPECT_CALL(*mock_network_library_, ethernet_connected())
239 .WillOnce(Return(true)); 229 .WillOnce(Return(true));
240 EXPECT_CALL(*mock_network_library_, Connected()) 230 EXPECT_CALL(*mock_network_library_, Connected())
241 .Times(3) 231 .Times(3)
242 .WillRepeatedly(Return(true)); 232 .WillRepeatedly(Return(true));
243 EXPECT_FALSE(actor_->IsContinueEnabled()); 233 // TODO(nkostylev): Add integration with WebUI actor http://crosbug.com/22570
244 EXPECT_FALSE(actor_->IsConnecting()); 234 // EXPECT_FALSE(actor_->IsContinueEnabled());
235 // EXPECT_FALSE(actor_->IsConnecting());
245 network_screen_->OnNetworkManagerChanged(mock_network_library_); 236 network_screen_->OnNetworkManagerChanged(mock_network_library_);
246 237
247 EXPECT_TRUE(actor_->IsContinueEnabled()); 238 // EXPECT_TRUE(actor_->IsContinueEnabled());
248 EmulateContinueButtonExit(network_screen_); 239 EmulateContinueButtonExit(network_screen_);
249 } 240 }
250 241
251 // See crbug.com/89392 242 // See crbug.com/89392
252 #if defined(OS_LINUX) 243 #if defined(OS_LINUX)
253 #define MAYBE_Timeout DISABLED_Timeout 244 #define MAYBE_Timeout DISABLED_Timeout
254 #else 245 #else
255 #define MAYBE_Timeout Timeout 246 #define MAYBE_Timeout Timeout
256 #endif 247 #endif
257 IN_PROC_BROWSER_TEST_F(NetworkScreenTest, MAYBE_Timeout) { 248 IN_PROC_BROWSER_TEST_F(NetworkScreenTest, MAYBE_Timeout) {
258 EXPECT_CALL(*mock_network_library_, ethernet_connected()) 249 EXPECT_CALL(*mock_network_library_, ethernet_connected())
259 .WillOnce((Return(false))); 250 .WillOnce((Return(false)));
260 EXPECT_CALL(*mock_network_library_, wifi_connected()) 251 EXPECT_CALL(*mock_network_library_, wifi_connected())
261 .WillOnce((Return(false))); 252 .WillOnce((Return(false)));
262 EXPECT_CALL(*mock_network_library_, cellular_connected()) 253 EXPECT_CALL(*mock_network_library_, cellular_connected())
263 .WillOnce((Return(false))); 254 .WillOnce((Return(false)));
264 EXPECT_CALL(*mock_network_library_, ethernet_connecting()) 255 EXPECT_CALL(*mock_network_library_, ethernet_connecting())
265 .WillOnce((Return(false))); 256 .WillOnce((Return(false)));
266 EXPECT_CALL(*mock_network_library_, wifi_connecting()) 257 EXPECT_CALL(*mock_network_library_, wifi_connecting())
267 .WillOnce((Return(true))); 258 .WillOnce((Return(true)));
268 scoped_ptr<WifiNetwork> wifi(new WifiNetwork("wifi")); 259 scoped_ptr<WifiNetwork> wifi(new WifiNetwork("wifi"));
269 EXPECT_CALL(*mock_network_library_, wifi_network()) 260 EXPECT_CALL(*mock_network_library_, wifi_network())
270 .WillOnce(Return(wifi.get())); 261 .WillOnce(Return(wifi.get()));
271 EXPECT_FALSE(actor_->IsContinueEnabled()); 262 // EXPECT_FALSE(actor_->IsContinueEnabled());
272 network_screen_->OnNetworkManagerChanged(mock_network_library_); 263 network_screen_->OnNetworkManagerChanged(mock_network_library_);
273 264
274 EXPECT_CALL(*mock_network_library_, Connected()) 265 EXPECT_CALL(*mock_network_library_, Connected())
275 .Times(2) 266 .Times(2)
276 .WillRepeatedly(Return(false)); 267 .WillRepeatedly(Return(false));
277 EXPECT_FALSE(actor_->IsContinueEnabled()); 268 // TODO(nkostylev): Add integration with WebUI actor http://crosbug.com/22570
278 EXPECT_FALSE(actor_->IsConnecting()); 269 // EXPECT_FALSE(actor_->IsContinueEnabled());
270 // EXPECT_FALSE(actor_->IsConnecting());
279 network_screen_->OnConnectionTimeout(); 271 network_screen_->OnConnectionTimeout();
280 272
281 // Close infobubble with error message - it makes the test stable. 273 // Close infobubble with error message - it makes the test stable.
282 EXPECT_FALSE(actor_->IsContinueEnabled()); 274 // EXPECT_FALSE(actor_->IsContinueEnabled());
283 EXPECT_FALSE(actor_->IsConnecting()); 275 // EXPECT_FALSE(actor_->IsConnecting());
284 actor_->ClearErrors(); 276 // actor_->ClearErrors();
285 } 277 }
286 278
287 } // namespace chromeos 279 } // namespace chromeos
OLDNEW
« no previous file with comments | « chrome/browser/chromeos/login/network_screen.cc ('k') | chrome/browser/chromeos/login/network_selection_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698