Issue 8431010: Split incremental marking write barrier into fast and slow paths.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8431010: Split incremental marking write barrier into fast and slow paths. (Closed)

Created:
9 years, 1 month ago by Vyacheslav Egorov (Chromium)

Modified:
9 years, 1 month ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Split incremental marking write barrier into fast and slow paths. Force inlining of the fast path. Force inlining LiteralBuffer::AddChar and Scanner::AddLiteralChar. R=erik.corry@gmail.com Committed: http://code.google.com/p/v8/source/detail?r=9853

Patch Set 1 #

Total comments: 3

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+76 lines, -51 lines)			Patch
M	src/incremental-marking.h	View	2 chunks	+14 lines, -7 lines	0 comments	Download
M	src/incremental-marking.cc	View	3 chunks	+39 lines, -1 line	3 comments	Download
M	src/incremental-marking-inl.h	View	1 chunk	+21 lines, -41 lines	0 comments	Download
M	src/scanner.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

9 years, 1 month ago (2011-10-31 19:48:33 UTC) #2

LGTM

http://codereview.chromium.org/8431010/diff/1/src/incremental-marking.cc
File src/incremental-marking.cc (right):

http://codereview.chromium.org/8431010/diff/1/src/incremental-marking.cc#newc...
src/incremental-marking.cc:126: Object** slot,
Formatting.

http://codereview.chromium.org/8431010/diff/1/src/incremental-marking.cc#newc...
src/incremental-marking.cc:146: // Object is either grey or white it will be
scanned if survives.
, or ; or : between "white" and "it"

http://codereview.chromium.org/8431010/diff/1/src/incremental-marking.cc#newc...
src/incremental-marking.cc:153: // Object is not going to be rescanned we need
to record the slot.
Punctuation before "we"

Expand Messages | Collapse Messages