Add WorkspaceObserver to observe changes in workspace state

Add WorkspaceObserver to observe changes in workspace state
Reduce dependencies amongst DCLM, ShowStateC, WorkspaceC and such.
 I changed my mind and kept "WorkspaceController owns WorkspaceManager" as this seems to be better in long run. I decoupled DCLM from ShowStateC and WorkspaceC. I moved a layout_in_progress flag to WorkspaceManager as it really belongs there, and can reduce dependency.


BUG=84070
TEST=new test conditions for workspace observer are added to workspace_manager_unittests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108301

[sky, 2011-11-02 03:57:49]

LGTM

http://codereview.chromium.org/8430024/diff/6001/ui/aura_shell/workspace/work...
File ui/aura_shell/workspace/workspace_manager.h (right):

http://codereview.chromium.org/8430024/diff/6001/ui/aura_shell/workspace/work...
ui/aura_shell/workspace/workspace_manager.h:39: aura::Window* viewport() {
return viewport_; }
nit: this actually isn't a viewport. A viewport is generally the size of the
visible region. This is really the underlying window, maybe it should be called
content_window. See the graphic on the right side of
http://download.oracle.com/javase/1.4.2/docs/api/javax/swing/JScrollPane.html 
as well as Viewport in views/controls/scroll_view.cc .

Don't change it in this patch, but it would be good to fix at some point.

http://codereview.chromium.org/8430024/diff/6001/ui/aura_shell/workspace/work...
ui/aura_shell/workspace/workspace_manager.h:76: // LayoutManager for this
workspace manager request must not modify
How about replacing the second sentence with: 'When true the LayoutManager gives
windows their requested bounds.'

http://codereview.chromium.org/8430024/diff/6001/ui/aura_shell/workspace/work...
ui/aura_shell/workspace/workspace_manager.h:78: bool layout_in_progress() const
nj{ return layout_in_progress_; }
remove 'nj'

http://codereview.chromium.org/8430024/diff/6001/ui/aura_shell/workspace/work...
File ui/aura_shell/workspace/workspace_observer.h (right):

http://codereview.chromium.org/8430024/diff/6001/ui/aura_shell/workspace/work...
ui/aura_shell/workspace/workspace_observer.h:5: #ifndef
UI_AURA_SHELL_WORKSPACE_WORKSPACEE_OBSERVER_H_
fix this

http://codereview.chromium.org/8430024/diff/6001/ui/aura_shell/workspace/work...
ui/aura_shell/workspace/workspace_observer.h:29: // Invoked when the active
workspace has chagned. |old| is
'has chagned' -> changes

[oshima, 2011-11-02 14:50:44]

On 2011/11/02 03:57:49, sky wrote:
> LGTM
> 
>
http://codereview.chromium.org/8430024/diff/6001/ui/aura_shell/workspace/work...
> File ui/aura_shell/workspace/workspace_manager.h (right):
> 
>
http://codereview.chromium.org/8430024/diff/6001/ui/aura_shell/workspace/work...
> ui/aura_shell/workspace/workspace_manager.h:39: aura::Window* viewport() {
> return viewport_; }
> nit: this actually isn't a viewport. A viewport is generally the size of the
> visible region. This is really the underlying window, maybe it should be
called
> content_window. See the graphic on the right side of
> http://download.oracle.com/javase/1.4.2/docs/api/javax/swing/JScrollPane.html 
> as well as Viewport in views/controls/scroll_view.cc .
> 
> Don't change it in this patch, but it would be good to fix at some point.

will do 
>
http://codereview.chromium.org/8430024/diff/6001/ui/aura_shell/workspace/work...
> ui/aura_shell/workspace/workspace_manager.h:76: // LayoutManager for this
> workspace manager request must not modify
> How about replacing the second sentence with: 'When true the LayoutManager
gives
> windows their requested bounds.'
done

>
http://codereview.chromium.org/8430024/diff/6001/ui/aura_shell/workspace/work...
> ui/aura_shell/workspace/workspace_manager.h:78: bool layout_in_progress()
const
> nj{ return layout_in_progress_; }
> remove 'nj'
> 
done

>http://codereview.chromium.org/8430024/diff/6001/ui/aura_shell/workspace/workspace_observer.h
> File ui/aura_shell/workspace/workspace_observer.h (right):
>
http://codereview.chromium.org/8430024/diff/6001/ui/aura_shell/workspace/work...
> ui/aura_shell/workspace/workspace_observer.h:5: #ifndef
> UI_AURA_SHELL_WORKSPACE_WORKSPACEE_OBSERVER_H_
> fix this
done
>
http://codereview.chromium.org/8430024/diff/6001/ui/aura_shell/workspace/work...
> ui/aura_shell/workspace/workspace_observer.h:29: // Invoked when the active
> workspace has chagned. |old| is
> 'has chagned' -> changes

done

[commit-bot: I haz the power, 2011-11-02 14:51:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/8430024/8001

[commit-bot: I haz the power, 2011-11-02 14:51:04]

Can't process patch for file
ui/aura_shell/default_container_layout_manager_unittest.cc.
File's status is None, patchset upload is incomplete.