Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8430019: Make LazyInstance managed Locks leaky. (Closed)

Created:
9 years, 1 month ago by Lei Zhang
Modified:
9 years, 1 month ago
CC:
chromium-reviews, jamiewalch+watch_chromium.org, garykac+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, dmaclach+watch_chromium.org, ajwong+watch_chromium.org, jam, apatrick_chromium, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, lambroslambrou+watch_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Make LazyInstance managed Locks leaky. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108159

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -18 lines) Patch
M base/mime_util_xdg.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/internal_auth.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/gpu/webgraphicscontext3d_command_buffer_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M remoting/host/local_input_monitor_mac.mm View 1 chunk +3 lines, -1 line 0 comments Download
M remoting/host/local_input_monitor_thread_win.cc View 1 chunk +3 lines, -1 line 0 comments Download
M ui/gfx/gl/gl_implementation_linux.cc View 1 chunk +3 lines, -1 line 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc View 4 chunks +5 lines, -6 lines 0 comments Download
M webkit/plugins/npapi/webplugin_ime_win.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Lei Zhang
If everyone can agree there's no need to destroy locks on shutdown, please LGTM. willchan: ...
9 years, 1 month ago (2011-11-01 01:21:18 UTC) #1
awong
remoting: ajwong -> wez (new TL)
9 years, 1 month ago (2011-11-01 01:23:11 UTC) #2
Wez
Rubber-stamp LGTM for remoting/.
9 years, 1 month ago (2011-11-01 01:26:49 UTC) #3
Ken Russell (switch to Gerrit)
GPU-related changes LGTM
9 years, 1 month ago (2011-11-01 05:56:43 UTC) #4
willchan no longer on Chromium
On 2011/11/01 05:56:43, kbr wrote: > GPU-related changes LGTM base LGTM
9 years, 1 month ago (2011-11-01 17:54:01 UTC) #5
Bernhard Bauer
webkit/plugins/ LGTM. On Tuesday, November 1, 2011, <willchan@chromium.org> wrote: > On 2011/11/01 05:56:43, kbr wrote: ...
9 years, 1 month ago (2011-11-01 19:09:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/8430019/1
9 years, 1 month ago (2011-11-01 19:11:24 UTC) #7
commit-bot: I haz the power
9 years, 1 month ago (2011-11-01 20:27:38 UTC) #8 
Change committed as 108159

Powered by Google App Engine
This is Rietveld 408576698