Issue 8430011: Revert 107967 - Introduces chromium_resources.gyp to factor out Chrome resource generation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8430011: Revert 107967 - Introduces chromium_resources.gyp to factor out Chrome resource generation (Closed)

Created:
9 years, 1 month ago by dhollowa

Modified:
9 years, 1 month ago

Reviewers:
dhollowa

CC:
chromium-reviews, jonathan.backer, Ian Vollick, tfarina, amit, robertshield, piman+watch_chromium.org, dhollowa

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 107967 - Introduces chromium_resources.gyp to factor out Chrome resource generation 1. Factors out Chrome/Chromium resource generation into a separate chrome_resources.gyp file. 2. Eliminates repetition between Mac and other platforms. 3. Breaks long "repack" actions out into separate files for greater readability. 4. Eliminates circular dependencies in the Aura shell, the Views components, and the compositor when utilizing Chrome resources. BUG=none TEST=try bots run gyps and build correctly. Review URL: http://codereview.chromium.org/8425002 TBR=dhollowa@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107984

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+713 lines, -632 lines)			Patch
M	chrome/chrome.gyp	View	8 chunks	+436 lines, -9 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+5 lines, -5 lines	0 comments	Download
M	chrome/chrome_common.gypi	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/chrome_dll.gypi	View	5 chunks	+156 lines, -10 lines	0 comments	Download
M	chrome/chrome_exe.gypi	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/chrome_installer_util.gypi	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/chrome_renderer.gypi	View	1 chunk	+2 lines, -2 lines	0 comments	Download
D	chrome/chrome_repack_chrome.gypi	View	1 chunk	+0 lines, -45 lines	0 comments	Download
D	chrome/chrome_repack_locales.gypi	View	1 chunk	+0 lines, -30 lines	0 comments	Download
D	chrome/chrome_repack_pseudo_locales.gypi	View	1 chunk	+0 lines, -38 lines	0 comments	Download
D	chrome/chrome_repack_resources.gypi	View	1 chunk	+0 lines, -33 lines	0 comments	Download
D	chrome/chrome_repack_theme_resources_large.gypi	View	1 chunk	+0 lines, -21 lines	0 comments	Download
D	chrome/chrome_resources.gyp	View	1 chunk	+0 lines, -367 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	19 chunks	+42 lines, -41 lines	0 comments	Download
M	chrome/nacl.gypi	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome_frame/chrome_frame.gyp	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	ui/aura/aura.gyp	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	ui/aura_shell/aura_shell.gyp	View	4 chunks	+14 lines, -2 lines	0 comments	Download
M	ui/gfx/compositor/compositor.gyp	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	views/views.gyp	View	11 chunks	+29 lines, -8 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages