Introduces chromium_resources.gyp to factor out Chrome resource generation

Introduces chromium_resources.gyp to factor out Chrome resource generation

1. Factors out Chrome/Chromium resource generation into a separate
chrome_resources.gyp file.
2. Eliminates repetition between Mac and other platforms.
3. Breaks long "repack" actions out into separate files for greater readability.
4. Eliminates circular dependencies in the Aura shell, the Views components, and
the compositor when utilizing Chrome resources.

BUG=none
TEST=try bots run gyps and build correctly.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107967

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108466

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108517

[dhollowa, 2011-10-31 02:25:10]

Mark, this work is motivated by the presence of circular dependencies I hit with
the Aura/Mac work.  Splitting off the chrome_resources.gyp as a separate file
eliminates this circularity.  I've managed also to reduce a lot of the
duplication between Mac and other platforms that was there due to the use of the
'process_outputs_as_mac_bundle_resources' flag.

sky -> views / aura / compositor changes.

Thanks!

[Mark Mentovai, 2011-10-31 12:51:01]

GYP LG otherwise.

http://codereview.chromium.org/8425002/diff/1/chrome/chrome_repack_theme_reso...
File chrome/chrome_repack_theme_resources_large.gypi (right):

http://codereview.chromium.org/8425002/diff/1/chrome/chrome_repack_theme_reso...
chrome/chrome_repack_theme_resources_large.gypi:1: {
Boilerplate?

[sky, 2011-10-31 14:34:00]

LGTM

http://codereview.chromium.org/8425002/diff/1/views/views.gyp
File views/views.gyp (right):

http://codereview.chromium.org/8425002/diff/1/views/views.gyp#newcode549
views/views.gyp:549: # TODO(jcivelli): ideally the resource needed by views
would be
nit: spacing is off here.

[dhollowa, 2011-10-31 14:41:15]

http://codereview.chromium.org/8425002/diff/1/chrome/chrome_repack_theme_reso...
File chrome/chrome_repack_theme_resources_large.gypi (right):

http://codereview.chromium.org/8425002/diff/1/chrome/chrome_repack_theme_reso...
chrome/chrome_repack_theme_resources_large.gypi:1: {
On 2011/10/31 12:51:01, Mark Mentovai wrote:
> Boilerplate?

Done.

http://codereview.chromium.org/8425002/diff/1/views/views.gyp
File views/views.gyp (right):

http://codereview.chromium.org/8425002/diff/1/views/views.gyp#newcode549
views/views.gyp:549: # TODO(jcivelli): ideally the resource needed by views
would be
On 2011/10/31 14:34:00, sky wrote:
> nit: spacing is off here.

Done.  Tabs snuck in somehow.

[Mark Mentovai, 2011-10-31 14:49:54]

LGTM

[dhollowa, 2011-11-02 18:51:04]

On 2011/10/31 14:49:54, Mark Mentovai wrote:
> LGTM

Mark, patch set 4 resolves some differences between make (trybots) and xcode
(waterfall).  Patch set 5 restores resources used by tests.  This should do it
now...  re-tested on win/mac/linux bots and locally with the xcode generator.

PTAL.

[Mark Mentovai, 2011-11-03 14:52:15]

LGTM

[M-A Ruel, 2011-11-03 16:24:12]

On 2011/11/03 14:52:15, Mark Mentovai wrote:
> LGTM

Try your patch next time.

[dhollowa, 2011-11-03 17:16:17]

In my defense, there are a couple things going on here.  1. The Mac trybots use
GYP_GENERATOR=make, but the waterfall uses GYP_GENERATOR=xcode.  So my first
all-green trybots didn't help me.  2. I'd run a couple clobber runs of the
trybots yesterday with the second round of changes but the Linux bots seemed to
be having trouble patching in a newish revision despite my specifying "-r
NEWISH" for the try run.  I got green on Mac and Win, and didn't think Linux was
going to be affected.

Anyway, I agree it is my responsibility to get things right.  But there has been
some "learnings" for me with this one...