clang: Let `gclient sync` autoupdate clang on linux if clang has been downloaded before.

clang: Let `gclient sync` autoupdate clang on linux if clang has been downloaded before.

This way, clang is autoupdated for people who use clang on linux, but people and bots
who don't use it are still not affected

BUG=none
TEST=linux clang users stop complaining to me about things that were fixed long ago.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108118

[Mark Mentovai, 2011-10-31 21:06:02]

http://codereview.chromium.org/8429020/diff/1/tools/clang/scripts/update.sh
File tools/clang/scripts/update.sh (right):

http://codereview.chromium.org/8429020/diff/1/tools/clang/scripts/update.sh#n...
tools/clang/scripts/update.sh:57: if ! [ -d "${LLVM_BUILD_DIR}" ]; then
Use [[ double ]] square brackets.

http://codereview.chromium.org/8429020/diff/1/tools/clang/scripts/update.sh#n...
tools/clang/scripts/update.sh:58: if [[ -n "$mac_only" ]] && [[ "${OS}" !=
"Darwin" ]]; then
Instead of wrapping an if instead of another if like this, why not use a single
if and && them together?

[(unused - use chromium), 2011-10-31 21:16:32]

http://codereview.chromium.org/8429020/diff/1/tools/clang/scripts/update.sh
File tools/clang/scripts/update.sh (right):

http://codereview.chromium.org/8429020/diff/1/tools/clang/scripts/update.sh#n...
tools/clang/scripts/update.sh:57: if ! [ -d "${LLVM_BUILD_DIR}" ]; then
On 2011/10/31 21:06:02, Mark Mentovai wrote:
> Use [[ double ]] square brackets.

Done.

http://codereview.chromium.org/8429020/diff/1/tools/clang/scripts/update.sh#n...
tools/clang/scripts/update.sh:58: if [[ -n "$mac_only" ]] && [[ "${OS}" !=
"Darwin" ]]; then
On 2011/10/31 21:06:02, Mark Mentovai wrote:
> Instead of wrapping an if instead of another if like this, why not use a
single
> if and && them together?

Seemed clearer to me for some reason. Changed.

[Mark Mentovai, 2011-10-31 21:20:50]

This is good. LGTM.

[commit-bot: I haz the power, 2011-10-31 21:22:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/8429020/1002

[commit-bot: I haz the power, 2011-10-31 22:25:59]

Try job failure for 8429020-1002 (retry) on linux_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2011-11-01 15:25:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/8429020/1002

[commit-bot: I haz the power, 2011-11-01 15:27:14]

Try job failure for 8429020-1002 on win_rel for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2011-11-01 15:29:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/8429020/6001

[commit-bot: I haz the power, 2011-11-01 16:48:58]

Change committed as 108118