clang: Let `gclient sync` autoupdate clang on linux if clang has been downloaded before.

tools/clang/scripts/update.sh

 #!/usr/bin/env bash
 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # This script will check out llvm and clang into third_party/llvm and build it.
 
 THIS_DIR="$(dirname "${0}")"
 LLVM_DIR="${THIS_DIR}/../../../third_party/llvm"
 LLVM_BUILD_DIR="${LLVM_DIR}/../llvm-build"
@@ skipping 24 matching lines @@
       ;;
     --mac-only)
       mac_only=yes
       ;;
     --run-tests)
       run_tests=yes
       ;;
     --help)
       echo "usage: $0 [--force-local-build] [--mac-only] [--run-tests] "
       echo "--force-local-build: Don't try to download prebuilt binaries."
-      echo "--mac-only: Do nothing on non-Mac systems."
+      echo "--mac-only: Do initial download only on Mac systems."
       echo "--run-tests: Run tests after building. Only for local builds."
       exit 1
       ;;
   esac
   shift
 done
 
-if [[ -n "$mac_only" ]] && [[ "${OS}" != "Darwin" ]]; then
-  exit 0
+# --mac-only prevents the initial download on non-mac systems, but if clang has
+# already been downloaded in the past, this script keeps it up to date even if
+# --mac-only is passed in and the system isn't a mac. People who don't like this
+# can just delete their third_party/llvm-build directory.
+if ! [ -d "${LLVM_BUILD_DIR}" ]; then

[Mark Mentovai, 2011/10/31 21:06:02]

Use [[ double ]] square brackets.

[(unused - use chromium), 2011/10/31 21:16:32]

Done.

+  if [[ -n "$mac_only" ]] && [[ "${OS}" != "Darwin" ]]; then

[Mark Mentovai, 2011/10/31 21:06:02]

Instead of wrapping an if instead of another if like this, why not use a single
if and && them together?

[(unused - use chromium), 2011/10/31 21:16:32]

Seemed clearer to me for some reason. Changed.

+    exit 0
+  fi
 fi
 
 # TODO(thakis): Remove this after Sept 29 2011. http://crbug.com/96722
 for rev in 138188 138417 139029 139473 139990; do
   rm -f clang-$rev.tgz
   rm -rf clang-$rev
 done
 
 # Xcode and clang don't get along when predictive compilation is enabled.
 # http://crbug.com/96315
@@ skipping 152 matching lines @@
 if [[ -n "$run_tests" ]]; then
   # Run a few tests.
   "${PLUGIN_SRC_DIR}/tests/test.sh" "${LLVM_BUILD_DIR}/Release+Asserts"
   cd "${LLVM_BUILD_DIR}"
   make check-all
   cd -
 fi
 
 # After everything is done, log success for this revision.
 echo "${CLANG_REVISION}" > "${STAMP_FILE}"