Issue 8429016: Autofill: unit test / valgrind; gyp tweak

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8429016: Autofill: unit test / valgrind; gyp tweak (Closed)

Created:
9 years, 1 month ago by John Grabowski

Modified:
9 years, 1 month ago

Reviewers:
Ilya Sherman, dhollowa

CC:
chromium-reviews, Alexander Potapenko, Timur Iskhodzhanov, jam, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., pam+watch_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Autofill: unit test / valgrind; gyp tweak Fix valgrind error in new unit test. Remove valgrind/heapcheck suppressions. Remove improper reference to a header that does not exist. BUG=102256 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108012

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -16 lines)			Patch
M	chrome/browser/autocomplete_history_manager_unittest.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	content/content_common.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tools/heapcheck/suppressions.txt	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	tools/valgrind/memcheck/suppressions.txt	View	1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

John Grabowski

Contains follow-up to post-submit feedback in http://codereview.chromium.org/8353025/

9 years, 1 month ago (2011-10-31 19:55:22 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jrg@chromium.org/8429016/1

9 years, 1 month ago (2011-10-31 20:04:46 UTC) #3

Change committed as 108012

Expand Messages | Collapse Messages