Autofill: unit test / valgrind; gyp tweak

chrome/browser/autocomplete_history_manager_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <vector>
 
 #include "base/memory/ref_counted.h"
 #include "base/string16.h"
 #include "base/task.h"
 #include "base/utf_string_conversions.h"
@@ skipping 146 matching lines @@
   DISALLOW_COPY_AND_ASSIGN(MockAutofillExternalDelegate);
 };
 
 class AutocompleteHistoryManagerStubSend : public AutocompleteHistoryManager {
  public:
   explicit AutocompleteHistoryManagerStubSend(TabContents* tab_contents,
                                               Profile* profile,
                                               WebDataService* wds)
       : AutocompleteHistoryManager(tab_contents, profile, wds) {}
 
-  virtual bool Send(IPC::Message* message) { return true; }  // intentional nop
+  // Intentionally swallow the message.
+  virtual bool Send(IPC::Message* message) { delete message; return true; }
 };
 
 }  // namespace
 
 // Make sure our external delegate is called at the right time.
 TEST_F(AutocompleteHistoryManagerTest, ExternalDelegate) {
   // Local version with a stubbed out Send()
   AutocompleteHistoryManagerStubSend autocomplete_history_manager(
       contents(),
       &profile_, web_data_service_);
 
   MockAutofillExternalDelegate external_delegate(
       TabContentsWrapper::GetCurrentWrapperForContents(contents()));
   EXPECT_CALL(external_delegate, OnSuggestionsReturned(_, _,  _,  _,  _));
   autocomplete_history_manager.SetExternalDelegate(&external_delegate);
 
   // Should trigger a call to OnSuggestionsReturned, verified by the mock.
   autocomplete_history_manager.SendSuggestions(NULL);
 }