chrome/browser/ui/views/shell_dialogs_win.cc - Issue 8427007: Thread::Stop() must be called before any subclass's destructor completes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/shell_dialogs_win.cc

Issue 8427007: Thread::Stop() must be called before any subclass's destructor completes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Latest version as trybot-ted Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/shell_dialogs_win.cc

diff --git a/chrome/browser/ui/views/shell_dialogs_win.cc b/chrome/browser/ui/views/shell_dialogs_win.cc

index faa4cb944990771ed76f476effabb3a09e70034c..38f51584b8876ce8d3f0304d9f9b2eeda353565f 100644

--- a/chrome/browser/ui/views/shell_dialogs_win.cc

+++ b/chrome/browser/ui/views/shell_dialogs_win.cc

@@ -383,6 +383,9 @@ bool SaveFileAs(HWND owner,

class ShellDialogThread : public base::Thread {

public:

ShellDialogThread() : base::Thread("Chrome_ShellDialogThread") { }

+ ~ShellDialogThread() {

+ Stop();

+ }

protected:

void Init() {

« no previous file with comments | « chrome/browser/printing/print_job_worker.cc ('k') | chrome/default_plugin/plugin_install_job_monitor.cc » ('j') | no next file with comments »