chrome/browser/printing/print_job_worker.cc - Issue 8427007: Thread::Stop() must be called before any subclass's destructor completes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/print_job_worker.cc

Issue 8427007: Thread::Stop() must be called before any subclass's destructor completes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Latest version as trybot-ted Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/printing/print_job_worker.cc

diff --git a/chrome/browser/printing/print_job_worker.cc b/chrome/browser/printing/print_job_worker.cc

index 19e967bea45a13ceb882562e0959151fc8fa2d56..1072fb5978682264f4e28f43398d427a753a008f 100644

--- a/chrome/browser/printing/print_job_worker.cc

+++ b/chrome/browser/printing/print_job_worker.cc

@@ -68,6 +68,7 @@ PrintJobWorker::~PrintJobWorker() {

// cancels printing or in the case of print preview, the worker is destroyed

// on the I/O thread.

DCHECK_EQ(owner_->message_loop(), MessageLoop::current());

+ Stop();

}

void PrintJobWorker::SetNewOwner(PrintJobWorkerOwner* new_owner) {

« no previous file with comments | « chrome/browser/metrics/thread_watcher.cc ('k') | chrome/browser/ui/views/shell_dialogs_win.cc » ('j') | no next file with comments »