Introduces chromium_resources.gyp to factor out Chrome resource generation

chrome/chrome_dll.gypi

 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 {
   'conditions': [
     ['OS=="mac" or OS=="win"', {
       'targets': [
         {
           'variables': {
             'conditions' : [
@@ skipping 15 matching lines @@
           'dependencies': [
             '<@(chromium_dependencies)',
             'app/policy/cloud_policy_codegen.gyp:policy',
           ],
           'conditions': [
             ['OS=="win"', {
               'product_name': 'chrome',
               'dependencies': [
                 # On Windows, link the dependencies (libraries) that make
                 # up actual Chromium functionality into this .dll.
+                'chrome_resources.gyp:chrome_resources',
                 'chrome_version_resources',
-                'chrome_resources',
                 'installer_util_strings',
                 '../content/content.gyp:content_worker',
                 '../crypto/crypto.gyp:crypto',
                 '../printing/printing.gyp:printing',
                 '../net/net.gyp:net_resources',
                 '../third_party/cld/cld.gyp:cld',
                 '../views/views.gyp:views',
                 '../webkit/support/webkit_support.gyp:webkit_resources',
               ],
               'sources': [
@@ skipping 235 matching lines @@
                 'app/theme/omnibox_history.pdf',
                 'app/theme/omnibox_http.pdf',
                 'app/theme/omnibox_https_invalid.pdf',
                 'app/theme/omnibox_https_valid.pdf',
                 'app/theme/omnibox_https_warning.pdf',
                 'app/theme/omnibox_search.pdf',
                 'app/theme/otr_icon.pdf',
                 'app/theme/star.pdf',
                 'app/theme/star_lit.pdf',
                 'browser/mac/install.sh',
+                 '<(SHARED_INTERMEDIATE_DIR)/repack/chrome.pak',
+                 '<(SHARED_INTERMEDIATE_DIR)/repack/resources.pak',
+                '<!@pymod_do_main(repack_locales -o -g <(grit_out_dir) -s <(SHARED_INTERMEDIATE_DIR) -x <(SHARED_INTERMEDIATE_DIR) <(locales))',
+                # Note: pseudo_locales are generated via the packed_resources
+                # dependency but not copied to the final target.  See
+                # common.gypi for more info.
               ],
               'mac_bundle_resources!': [
                 'app/framework-Info.plist',
               ],
               'dependencies': [
                 # Bring in pdfsqueeze and run it on all pdfs
                 '../build/temp_gyp/pdfsqueeze.gyp:pdfsqueeze',
                 '../crypto/crypto.gyp:crypto',
                 # On Mac, Flash gets put into the framework, so we need this
                 # dependency here. flash_player.gyp will copy the Flash bundle
                 # into PRODUCT_DIR.
                 '../third_party/adobe/flash/flash_player.gyp:flash_player',
+                'chrome_resources.gyp:packed_extra_resources',
+                'chrome_resources.gyp:packed_resources',
               ],
               'rules': [
                 {
                   'rule_name': 'pdfsqueeze',
                   'extension': 'pdf',
                   'inputs': [
                     '<(PRODUCT_DIR)/pdfsqueeze',
                   ],
                   'outputs': [
                     '<(INTERMEDIATE_DIR)/pdfsqueeze/<(RULE_INPUT_ROOT).pdf',
                   ],
                   'action': ['<(PRODUCT_DIR)/pdfsqueeze',
                              '<(RULE_INPUT_PATH)', '<@(_outputs)'],
                   'message': 'Running pdfsqueeze on <(RULE_INPUT_PATH)',
                 },
               ],
               'variables': {
                 'conditions': [
                   ['branding=="Chrome"', {
                     'theme_dir_name': 'google_chrome',
                   }, {  # else: 'branding!="Chrome"
                     'theme_dir_name': 'chromium',
                   }],
                 ],
                 'repack_path': '../tools/grit/grit/format/repack.py',
               },
               'actions': [
-                # TODO(mark): These actions are duplicated for Linux and
-                # FreeBSD in the chrome target.  Can they be unified?
                 {
-                  'action_name': 'repack_chrome',
-                  'variables': {
-                    'pak_inputs': [
-                      '<(grit_out_dir)/browser_resources.pak',
-                      '<(grit_out_dir)/common_resources.pak',
-                      '<(grit_out_dir)/default_plugin_resources/default_plugin_resources.pak',
-                      '<(grit_out_dir)/renderer_resources.pak',
-                      '<(grit_out_dir)/theme_resources.pak',
-                      '<(grit_out_dir)/theme_resources_standard.pak',
-                      '<(SHARED_INTERMEDIATE_DIR)/net/net_resources.pak',
-                      '<(SHARED_INTERMEDIATE_DIR)/ui/ui_resources/ui_resources.pak',
-                      '<(SHARED_INTERMEDIATE_DIR)/ui/ui_resources_standard/ui_resources_standard.pak',
-                      '<(SHARED_INTERMEDIATE_DIR)/webkit/webkit_chromium_resources.pak',
-                      '<(SHARED_INTERMEDIATE_DIR)/webkit/webkit_resources.pak',
-                    ],
-                  },
-                  'inputs': [
-                    '<(repack_path)',
-                    '<@(pak_inputs)',
-                  ],
-                  'outputs': [
-                    '<(INTERMEDIATE_DIR)/repack/chrome.pak',
-                  ],
-                  'action': ['python', '<(repack_path)', '<@(_outputs)',
-                             '<@(pak_inputs)'],
-                  'process_outputs_as_mac_bundle_resources': 1,
-                },
-                {
-                  'action_name': 'repack_theme_resources_large',
-                  'variables': {
-                    'pak_inputs': [
-                      '<(grit_out_dir)/theme_resources_large.pak',
-                    ],
-                  },
-                  'inputs': [
-                    '<(repack_path)',
-                    '<@(pak_inputs)',
-                  ],
-                  'outputs': [
-                    '<(INTERMEDIATE_DIR)/repack/theme_resources_large.pak',
-                  ],
-                  'action': ['python', '<(repack_path)', '<@(_outputs)',
-                             '<@(pak_inputs)'],
-                  'process_outputs_as_mac_bundle_resources': 1,
-                },
-                {
-                  'action_name': 'repack_locales',
-                  'process_outputs_as_mac_bundle_resources': 1,
-                  'variables': {
-                    'conditions': [
-                      ['branding=="Chrome"', {
-                        'branding_flag': ['-b', 'google_chrome',],
-                      }, {  # else: branding!="Chrome"
-                        'branding_flag': ['-b', 'chromium',],
-                      }],
-                    ],
-                  },
-                  'inputs': [
-                    'tools/build/repack_locales.py',
-                    # NOTE: Ideally the common command args would be shared
-                    # amongst inputs/outputs/action, but the args include shell
-                    # variables which need to be passed intact, and command
-                    # expansion wants to expand the shell variables. Adding the
-                    # explicit quoting here was the only way it seemed to work.
-                    '>!@(<(repack_locales_cmd) -i <(branding_flag) -g \'<(grit_out_dir)\' -s \'<(SHARED_INTERMEDIATE_DIR)\' -x \'<(INTERMEDIATE_DIR)\' <(locales))',
-                  ],
-                  'outputs': [
-                    '>!@(<(repack_locales_cmd) -o -g \'<(grit_out_dir)\' -s \'<(SHARED_INTERMEDIATE_DIR)\' -x \'<(INTERMEDIATE_DIR)\' <(locales))',
-                  ],
-                  'action': [
-                    '<@(repack_locales_cmd)',
-                    '<@(branding_flag)',
-                    '-g', '<(grit_out_dir)',
-                    '-s', '<(SHARED_INTERMEDIATE_DIR)',
-                    '-x', '<(INTERMEDIATE_DIR)',
-                    '<@(locales)',
-                  ],
-                },
-                {
-                  # This is an exact copy of the above phase, except for two
-                  # changes:
-                  # 1. process_outputs_as_mac_bundle_resources is omitted.
-                  # 2. We pass 'pseudo_locales' instead of 'locales' wherever
-                  #    'locales' is used.
-                  # The result is a build phase that builds all pseudo locales
-                  # but doesn't copy them to the final dll/framework.
-                  'action_name': 'repack_pseudo_locales',
-                  'variables': {
-                    'conditions': [
-                      ['branding=="Chrome"', {
-                        'branding_flag': ['-b', 'google_chrome',],
-                      }, {  # else: branding!="Chrome"
-                        'branding_flag': ['-b', 'chromium',],
-                      }],
-                    ],
-                  },
-                  'inputs': [
-                    'tools/build/repack_locales.py',
-                    # NOTE: Ideally the common command args would be shared
-                    # amongst inputs/outputs/action, but the args include shell
-                    # variables which need to be passed intact, and command
-                    # expansion wants to expand the shell variables. Adding the
-                    # explicit quoting here was the only way it seemed to work.
-                    '>!@(<(repack_locales_cmd) -i <(branding_flag) -g \'<(grit_out_dir)\' -s \'<(SHARED_INTERMEDIATE_DIR)\' -x \'<(INTERMEDIATE_DIR)\' <(pseudo_locales))',
-                  ],
-                  'outputs': [
-                    '<(INTERMEDIATE_DIR)/<(pseudo_locales).pak'
-                  ],
-                  'action': [
-                    '<@(repack_locales_cmd)',
-                    '<@(branding_flag)',
-                    '-g', '<(grit_out_dir)',
-                    '-s', '<(SHARED_INTERMEDIATE_DIR)',
-                    '-x', '<(INTERMEDIATE_DIR)',
-                    '<@(pseudo_locales)',
-                  ],
-                },
-                {
-                  'action_name': 'repack_resources',
-                  'variables': {
-                    'pak_inputs': [
-                      '<(grit_out_dir)/component_extension_resources.pak',
-                      '<(grit_out_dir)/devtools_frontend_resources.pak',
-                      '<(grit_out_dir)/devtools_resources.pak',
-                      '<(grit_out_dir)/net_internals_resources.pak',
-                      '<(grit_out_dir)/options_resources.pak',
-                      '<(grit_out_dir)/quota_internals_resources.pak',
-                      '<(grit_out_dir)/shared_resources.pak',
-                      '<(grit_out_dir)/sync_internals_resources.pak',
-                      '<(grit_out_dir)/workers_resources.pak',
-                    ],
-                  },
-                  'inputs': [
-                    '<(repack_path)',
-                    '<@(pak_inputs)',
-                  ],
-                  'outputs': [
-                    '<(INTERMEDIATE_DIR)/repack/resources.pak',
-                  ],
-                  'action': ['python', '<(repack_path)', '<@(_outputs)',
-                             '<@(pak_inputs)'],
-                  'process_outputs_as_mac_bundle_resources': 1,
+                  'includes': ['chrome_repack_theme_resources_large.gypi']
                 },
               ],
               'postbuilds': [
                 {
                   # This step causes an error to be raised if the .order file
                   # does not account for all global text symbols.  It
                   # validates the completeness of the .order file.
                   'postbuild_name': 'Verify global text symbol order',
                   'variables': {
                     'verify_order_path': 'tools/build/mac/verify_order',
@@ skipping 59 matching lines @@
                       'files': [
                         '<(PRODUCT_DIR)/ppGoogleNaClPluginChrome.plugin',
                         # We leave out nacl_irt_x86_64.nexe because we only
                         # support x86-32 NaCl on Mac OS X.
                         '<(PRODUCT_DIR)/nacl_irt_x86_32.nexe',
                       ],
                     }],
                   ],
                 },
                 {
+                  # Copy of resources used by tests.
                   'destination': '<(PRODUCT_DIR)',
                   'files': [
-                      '<(INTERMEDIATE_DIR)/repack/resources.pak'
+                      '<(SHARED_INTERMEDIATE_DIR)/repack/resources.pak'
                   ],
                 },
                 {
+                  # Copy of resources used by tests.
                   'destination': '<(PRODUCT_DIR)/pseudo_locales',
                   'files': [
-                      '<(INTERMEDIATE_DIR)/<(pseudo_locales).pak'
+                      '<(SHARED_INTERMEDIATE_DIR)/<(pseudo_locales).pak'
                   ],
                 },
                 {
                   'destination': '<(PRODUCT_DIR)/$(CONTENTS_FOLDER_PATH)/resources',
                   'files': [],
                   'conditions': [
                     ['debug_devtools!=0', {
                       'files': [
                          '<(PRODUCT_DIR)/resources/inspector',
                       ],
@@ skipping 75 matching lines @@
                   ],
                 }],
               ],  # conditions
             }],  # OS=="mac"
           ],  # conditions
         },  # target chrome_dll
       ],  # targets
     }],  # OS=="mac" or OS=="win"
   ],
 }