chrome/browser/ui/panels/panel_settings_menu_model.cc - Issue 8423060: Classification of TODOs in Panel code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/panels/panel_settings_menu_model.cc

Issue 8423060: Classification of TODOs in Panel code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: cr feedback Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/panels/panel_settings_menu_model.cc

diff --git a/chrome/browser/ui/panels/panel_settings_menu_model.cc b/chrome/browser/ui/panels/panel_settings_menu_model.cc

index dd8a5fb90316fca9fc25b0cf8d9930f9f2774531..ee869558661e6e729203c5633667eb21ba35b4d6 100644

--- a/chrome/browser/ui/panels/panel_settings_menu_model.cc

+++ b/chrome/browser/ui/panels/panel_settings_menu_model.cc

@@ -91,6 +91,7 @@ void PanelSettingsMenuModel::ExecuteCommand(int command_id) {

case COMMAND_UNINSTALL:

// TODO(jianli): Need to handle the case that the extension API requests

// the panel to be closed when the uninstall dialog is still showing.

+ // http://crbug.com/102742

extension_uninstall_dialog_.reset(

ExtensionUninstallDialog::Create(browser->GetProfile(), this));

extension_uninstall_dialog_->ConfirmUninstall(extension);