Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: chrome/browser/ui/panels/panel_manager.cc

Issue 8423060: Classification of TODOs in Panel code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: cr feedback Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/panels/panel_manager.h ('k') | chrome/browser/ui/panels/panel_settings_menu_model.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/panels/panel_manager.cc
diff --git a/chrome/browser/ui/panels/panel_manager.cc b/chrome/browser/ui/panels/panel_manager.cc
index d2795eeb08e3b292d279505f780453399610c59d..f22c7d2bab7e2b4e626c113767e24b3e9da0e044 100644
--- a/chrome/browser/ui/panels/panel_manager.cc
+++ b/chrome/browser/ui/panels/panel_manager.cc
@@ -429,10 +429,9 @@ void PanelManager::BringUpOrDownTitlebars(bool bring_up) {
// it makes it possible to hit the titlebar on OSX if Dock has Magnifying
// enabled - the panels stay up for a while after Dock magnification effect
// stops covering the panels.
- // TODO(dimich): when there is implementation which has both delays to be
- // different from zero, figure out what shoudl be the combined delay.
- if (!bring_up &&
- task_delay_milliseconds < kMillisecondsBeforeCollapsingFromTitleOnlyState)
+ // Currently, no platforms use both delays.
+ DCHECK(task_delay_milliseconds == 0);
+ if (!bring_up)
task_delay_milliseconds = kMillisecondsBeforeCollapsingFromTitleOnlyState;
// OnAutoHidingDesktopBarVisibilityChanged will handle this.
« no previous file with comments | « chrome/browser/ui/panels/panel_manager.h ('k') | chrome/browser/ui/panels/panel_settings_menu_model.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698