Issue 8423005: Remove some unnecessary binding initialization checks.

Issue 8423005: Remove some unnecessary binding initialization checks. (Closed)

Created:
9 years, 1 month ago by Steven

Modified:
9 years, 1 month ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Remove some unnecessary binding initialization checks. This depends on http://codereview.chromium.org/8352039/ . Committed: http://code.google.com/p/v8/source/detail?r=9869

Patch Set 1 #

Total comments: 6

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+208 lines, -72 lines)			Patch
M	src/arm/full-codegen-arm.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/ia32/full-codegen-ia32.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/mips/full-codegen-mips.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/objects.h	View	4 chunks	+24 lines, -11 lines	0 comments	Download
M	src/parser.cc	View	3 chunks	+11 lines, -3 lines	0 comments	Download
M	src/scopeinfo.h	View	4 chunks	+20 lines, -5 lines	0 comments	Download
M	src/scopeinfo.cc	View	10 chunks	+36 lines, -14 lines	0 comments	Download
M	src/scopes.h	View	2 chunks	+5 lines, -2 lines	2 comments	Download
M	src/scopes.cc	View	10 chunks	+53 lines, -22 lines	0 comments	Download
M	src/v8globals.h	View	1 chunk	+37 lines, -0 lines	2 comments	Download
M	src/variables.h	View	4 chunks	+7 lines, -4 lines	2 comments	Download
M	src/variables.cc	View	2 chunks	+7 lines, -3 lines	0 comments	Download
M	src/x64/full-codegen-x64.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM with nits. http://codereview.chromium.org/8423005/diff/1/src/scopes.h File src/scopes.h (right): http://codereview.chromium.org/8423005/diff/1/src/scopes.h#newcode56 src/scopes.h:56: InitializationFlag); s/InitializationFlag/InitializationFlag initialization_flag/ http://codereview.chromium.org/8423005/diff/1/src/v8globals.h File src/v8globals.h ...

9 years, 1 month ago (2011-10-31 12:44:34 UTC) #2

Steven

9 years, 1 month ago (2011-10-31 14:28:29 UTC) #3

Will land this after landing the dependency.

http://codereview.chromium.org/8423005/diff/1/src/scopes.h
File src/scopes.h (right):

http://codereview.chromium.org/8423005/diff/1/src/scopes.h#newcode56
src/scopes.h:56: InitializationFlag);
On 2011/10/31 12:44:34, Jakob wrote:
> s/InitializationFlag/InitializationFlag initialization_flag/

Done.

http://codereview.chromium.org/8423005/diff/1/src/v8globals.h
File src/v8globals.h (right):

http://codereview.chromium.org/8423005/diff/1/src/v8globals.h#newcode573
src/v8globals.h:573: // properties of some object. In the specification only
mutable bindings exists
On 2011/10/31 12:44:34, Jakob wrote:
> nit: s/exists/exist/

Done.

http://codereview.chromium.org/8423005/diff/1/src/variables.h
File src/variables.h (right):

http://codereview.chromium.org/8423005/diff/1/src/variables.h#newcode81
src/variables.h:81: InitializationFlag initialization_flag_);
On 2011/10/31 12:44:34, Jakob wrote:
> nit: no trailing underscore

Done.

Expand Messages | Collapse Messages