src/ia32/full-codegen-ia32.cc - Issue 8423005: Remove some unnecessary binding initialization checks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/full-codegen-ia32.cc

Issue 8423005: Remove some unnecessary binding initialization checks. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/full-codegen-ia32.cc

diff --git a/src/ia32/full-codegen-ia32.cc b/src/ia32/full-codegen-ia32.cc

index 23cc5aba30746445d9fbcacd31cce8907135e944..99a26722bf2def0701deb564e35f3492775cbe5e 100644

--- a/src/ia32/full-codegen-ia32.cc

+++ b/src/ia32/full-codegen-ia32.cc

@@ -714,8 +714,8 @@ void FullCodeGenerator::EmitDeclaration(VariableProxy* proxy,

// need to "declare" it at runtime to make sure it actually exists in the

// local context.

Variable* variable = proxy->var();

- bool binding_needs_init =

- mode == CONST || mode == CONST_HARMONY || mode == LET;

+ bool binding_needs_init = (function == NULL) &&

+ (mode == CONST || mode == CONST_HARMONY || mode == LET);

switch (variable->location()) {

case Variable::UNALLOCATED:

++(*global_count);