Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Unified Diff: corelib/src/list.dart

Issue 8422005: Remove List.fromList constructor, and List.copyFrom. They are duplicates of the new range methods. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: corelib/src/list.dart
===================================================================
--- corelib/src/list.dart (revision 938)
+++ corelib/src/list.dart (working copy)
@@ -20,16 +20,6 @@
List.from(Iterable<E> other);
/**
- * Creates a list which is a subcopy of [other], starting at
- * [startIndex] (inclusive) and ending at [endIndex] (exclusive). If
- * [startIndex] is negative, it has the same effect as if it were
- * zero. If [endIndex] is greather than the length, it has the same
- * effect as if it were [:other.length:]. If [:startIndex > endIndex:],
- * the created list is of [length] 0.
- */
- List.fromList(List<E> other, int startIndex, int endIndex);
-
- /**
* Returns the element at the given [index] in the list or throws
* an [IndexOutOfRangeException] if [index] is out of bounds.
*/
@@ -85,16 +75,6 @@
void sort(int compare(E a, E b));
/**
- * Copies [count] elements from the [src] list starting at index
- * [srcStart] to this list starting at index [dstStart].
- *
- * The type of [src] is List<Object> because one must be able to
- * give a List<Object> only containing eg. String objects and copy
- * its elements into a List<String>.
- */
- void copyFrom(List<Object> src, int srcStart, int dstStart, int count);
-
- /**
* Returns the first index of [element] in this list. Searches this
* list from index [startIndex] to the length of the list. Returns
* -1 if [element] is not found.

Powered by Google App Engine
This is Rietveld 408576698