Bookmark bar menu/folder button text is left-aligned, not centered....

Bookmark bar menu/folder button text is left-aligned, not centered.
Bookmark bar menu/folder maximum window width is now 1000, not 150.

High cosmetic impact.

BUG=36487, 17608
TEST=\
1) Add bookmarks on the bar with small (e.g. 'x') and big titles.
Make sure all looks OK (e.g. small ones are small.)
2) Add bookmarks in a folder.
Make sure text is left aligned on the menus.
3) Add bookmarks in a folder with long names (e.g. 100 characters).
Make sure folder/menus are now much wider.
4) Add bookmarks in a folder with mega long names (e.g. 4000 characters).
Make sure menus have a maximum size of ~1000 pixes (no need to be exact but 'no limit' is fail).
5) In a folder, add a subfolder named 'x' and a bookmark with a REAL long name.
Make sure the "button" (menu item) is the full width of the menu.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=41387

[Miranda Callahan, 2010-03-12 02:24:29]

LGTM.

http://codereview.chromium.org/842005/diff/3001/4003
File chrome/browser/cocoa/bookmark_bar_folder_controller.mm (right):

http://codereview.chromium.org/842005/diff/3001/4003#newcode93
chrome/browser/cocoa/bookmark_bar_folder_controller.mm:93: // Adjusts the input
frame with as appropriate.
with ... ?

[Nico, 2010-03-12 02:28:35]

LG. Minor nits below.

http://codereview.chromium.org/842005/diff/3001/4003
File chrome/browser/cocoa/bookmark_bar_folder_controller.mm (right):

http://codereview.chromium.org/842005/diff/3001/4003#newcode109
chrome/browser/cocoa/bookmark_bar_folder_controller.mm:109:
bookmarks::kBookmarkMenuButtonMaximumWidth);
I wish we had a clamp(value, minAllowed, maxAllowed) function; would be more
readable.

http://codereview.chromium.org/842005/diff/3001/4003#newcode202
chrome/browser/cocoa/bookmark_bar_folder_controller.mm:202: int windowWidth =
(bookmarks::kDefaultBookmarkWidth +
initialWidth maybe?

http://codereview.chromium.org/842005/diff/3001/4003#newcode205
chrome/browser/cocoa/bookmark_bar_folder_controller.mm:205: [[self window]
setFrame:NSMakeRect(newWindowTopLeft.x,
I'd put this rect in a variable windowFrame and... (see below)

http://codereview.chromium.org/842005/diff/3001/4003#newcode213
chrome/browser/cocoa/bookmark_bar_folder_controller.mm:213: NSRect frame =
NSMakeRect(bookmarks::kBookmarkHorizontalPadding,
call this buttonFrame?

http://codereview.chromium.org/842005/diff/3001/4003#newcode259
chrome/browser/cocoa/bookmark_bar_folder_controller.mm:259: frame =
NSMakeRect(newWindowTopLeft.x,
...just set the new width of windowFrame here

[John Grabowski, 2010-03-12 03:11:54]

All feedback applied.  Thanks guys.