Bookmark bar menu/folder button text is left-aligned, not centered....

chrome/browser/cocoa/bookmark_bar_folder_controller_unittest.mm

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <Cocoa/Cocoa.h>
 
 #include "base/basictypes.h"
 #include "base/scoped_nsobject.h"
 #import "chrome/browser/cocoa/bookmark_bar_controller.h"
 #import "chrome/browser/cocoa/bookmark_bar_folder_controller.h"
@@ skipping 20 matching lines @@
 
 - (void)childFolderWillClose:(id<BookmarkButtonControllerProtocol>)child {
   childFolderWillClose_ = YES;
 }
 @end
 
 class BookmarkBarFolderControllerTest : public CocoaTest {
  public:
   BrowserTestHelper helper_;
   scoped_nsobject<BookmarkBarController> parentBarController_;
+  const BookmarkNode* longTitleNode_;  // owned by model
 
   BookmarkBarFolderControllerTest() {
     BookmarkModel* model = helper_.profile()->GetBookmarkModel();
     const BookmarkNode* parent = model->GetBookmarkBarNode();
     const BookmarkNode* folderA = model->AddGroup(parent,
                                                   parent->GetChildCount(),
                                                   L"group");
     model->AddGroup(parent, parent->GetChildCount(),
                     L"sibbling group");
     const BookmarkNode* folderB = model->AddGroup(folderA,
                                                   folderA->GetChildCount(),
                                                   L"subgroup");
     model->AddURL(folderA, folderA->GetChildCount(), L"title a",
                   GURL("http://www.google.com/a"));
-    model->AddURL(folderA, folderA->GetChildCount(),
-                  L"title super duper long long whoa momma title you betcha",
-                  GURL("http://www.google.com/b"));
+    longTitleNode_ = model->AddURL(
+      folderA, folderA->GetChildCount(),
+      L"title super duper long long whoa momma title you betcha",
+      GURL("http://www.google.com/b"));
     model->AddURL(folderB, folderB->GetChildCount(), L"t",
                   GURL("http://www.google.com/c"));
 
     parentBarController_.reset(
       [[BookmarkBarController alloc]
           initWithBrowser:helper_.browser()
              initialWidth:300
                  delegate:nil
            resizeDelegate:nil]);
     [parentBarController_ loaded:model];
   }
 
+  // Remove the bookmark with the long title.
+  void RemoveLongTitleNode() {
+    BookmarkModel* model = helper_.profile()->GetBookmarkModel();
+    model->Remove(longTitleNode_->GetParent(),
+                  longTitleNode_->GetParent()->IndexOfChild(longTitleNode_));
+  }
+
   // Return a simple BookmarkBarFolderController.
   BookmarkBarFolderController* SimpleBookmarkBarFolderController() {
     BookmarkButton* parentButton = [[parentBarController_ buttons]
                                      objectAtIndex:0];
     return [[BookmarkBarFolderControllerPong alloc]
                initWithParentButton:parentButton
                    parentController:parentBarController_];
   }
 
 };
@@ skipping 144 matching lines @@
 
   EXPECT_FALSE([bbfc childFolderWillShow]);
   [bbfc openBookmarkFolderFromButton:[[bbfc buttons] objectAtIndex:0]];
   EXPECT_TRUE([bbfc childFolderWillShow]);
 
   EXPECT_FALSE([bbfc childFolderWillClose]);
   [bbfc closeBookmarkFolder:nil];
   EXPECT_TRUE([bbfc childFolderWillClose]);
 }
 
+// Make sure bookmark folders have variable widths.
+TEST_F(BookmarkBarFolderControllerTest, ChildFolderWidth) {
+  scoped_nsobject<BookmarkBarFolderController> bbfc;
+
+  bbfc.reset(SimpleBookmarkBarFolderController());
+  EXPECT_TRUE(bbfc.get());
+  CGFloat wideWidth = NSWidth([[bbfc window] frame]);
+
+  RemoveLongTitleNode();
+  bbfc.reset(SimpleBookmarkBarFolderController());
+  EXPECT_TRUE(bbfc.get());
+  CGFloat thinWidth = NSWidth([[bbfc window] frame]);
+
+  // Make sure window size changed as expected.
+  EXPECT_GT(wideWidth, thinWidth);
+}
+
+
+
 // TODO(jrg): draggingEntered: and draggingExited: trigger timers so
 // they are hard to test.  Factor out "fire timers" into routines
 // which can be overridden to fire immediately to make behavior
 // confirmable.
 // There is a similar problem with mouseEnteredButton: and
 // mouseExitedButton:.