Add dependency.

Add dependencies.

BUG=102056
TEST=links without warning with GYP_DEFINES="use_aura=1 use_webkit_compositor=1 component=shared_library"


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107775

[jonathan.backer, 2011-10-28 14:58:18]

This compiles clean without warning with and without the component build when
use_webkit_compositor=1 is active.

Most of the dependencies that I pulled in are in chrome_browser or
content_common.

I think that the GYPs in src/webkit need some love. However, I'm not the one to
do it (no background).

In particular webkit_support:glue depends on webkit_support:fileapi but that
dependency is not there.

I'm content with this low road with the understanding that this will all change
once the WK compositor is pulled into its own library.

[jonathan.backer, 2011-10-28 15:00:16]

+piman

[sky, 2011-10-28 17:41:56]

LGTM

[piman, 2011-10-28 17:55:04]

lgtm

[commit-bot: I haz the power, 2011-10-28 18:53:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/backer@chromium.org/8418022/2001

[commit-bot: I haz the power, 2011-10-28 19:54:38]

Change committed as 107775

[oshima, 2011-11-17 21:14:19]

http://codereview.chromium.org/8418022/diff/2001/ui/gfx/compositor/compositor...
File ui/gfx/compositor/compositor.gyp (right):

http://codereview.chromium.org/8418022/diff/2001/ui/gfx/compositor/compositor...
ui/gfx/compositor/compositor.gyp:120:
'<(DEPTH)/base/allocator/allocator.gyp:allocator',
backer, this is causing problem when building asan which requires asan
allocator. Do you know why we need this here?

[dhollowa, 2011-11-17 21:42:28]

http://codereview.chromium.org/8418022/diff/2001/ui/gfx/compositor/compositor...
File ui/gfx/compositor/compositor.gyp (right):

http://codereview.chromium.org/8418022/diff/2001/ui/gfx/compositor/compositor...
ui/gfx/compositor/compositor.gyp:120:
'<(DEPTH)/base/allocator/allocator.gyp:allocator',
On 2011/11/17 21:14:20, oshima wrote:
> backer, this is causing problem when building asan which requires asan
> allocator. Do you know why we need this here?

This should be guarded by the condition 'linux_use_tcmalloc==1'.

[piman, 2011-11-17 21:47:30]

On 2011/11/17 21:42:28, dhollowa wrote:
>
http://codereview.chromium.org/8418022/diff/2001/ui/gfx/compositor/compositor...
> File ui/gfx/compositor/compositor.gyp (right):
> 
>
http://codereview.chromium.org/8418022/diff/2001/ui/gfx/compositor/compositor...
> ui/gfx/compositor/compositor.gyp:120:
> '<(DEPTH)/base/allocator/allocator.gyp:allocator',
> On 2011/11/17 21:14:20, oshima wrote:
> > backer, this is causing problem when building asan which requires asan
> > allocator. Do you know why we need this here?
> 
> This should be guarded by the condition 'linux_use_tcmalloc==1'.

I have a fix in http://codereview.chromium.org/8565019/ but unfortunately that
CL won't go in immediately. I'll rubber stamp LGTM any CL that fixes it.

[oshima, 2011-11-17 21:56:58]

Thanks. one nit: you don't need  OS="linux" because linux_uses_tcmalloc is
linux only flag.


- oshima


On Thu, Nov 17, 2011 at 1:47 PM, <piman@chromium.org> wrote:

> On 2011/11/17 21:42:28, dhollowa wrote:
>
> http://codereview.chromium.**org/8418022/diff/2001/ui/gfx/**
>
compositor/compositor.gyp<http://codereview.chromium.org/8418022/diff/2001/ui/gfx/compositor/compositor.gyp>
>
>> File ui/gfx/compositor/compositor.**gyp (right):
>>
>
>
> http://codereview.chromium.**org/8418022/diff/2001/ui/gfx/**
>
compositor/compositor.gyp#**newcode120<http://codereview.chromium.org/8418022/diff/2001/ui/gfx/compositor/compositor.gyp#newcode120>
>
>> ui/gfx/compositor/compositor.**gyp:120:
>> '<(DEPTH)/base/allocator/**allocator.gyp:allocator',
>> On 2011/11/17 21:14:20, oshima wrote:
>> > backer, this is causing problem when building asan which requires asan
>> > allocator. Do you know why we need this here?
>>
>
>  This should be guarded by the condition 'linux_use_tcmalloc==1'.
>>
>
> I have a fix in
http://codereview.chromium.**org/8565019/<http://codereview.chromium.org/8565...
unfortunately that
> CL won't go in immediately. I'll rubber stamp LGTM any CL that fixes it.
>
>
http://codereview.chromium.**org/8418022/<http://codereview.chromium.org/8418...
>

[dhollowa, 2011-11-17 21:58:31]

http://codereview.chromium.org/8591029

On 2011/11/17 21:56:58, oshima wrote:
> Thanks. one nit: you don't need  OS="linux" because linux_uses_tcmalloc is
> linux only flag.
> 
> 
> - oshima
> 
> 
> On Thu, Nov 17, 2011 at 1:47 PM, <mailto:piman@chromium.org> wrote:
> 
> > On 2011/11/17 21:42:28, dhollowa wrote:
> >
> > http://codereview.chromium.**org/8418022/diff/2001/ui/gfx/**
> >
>
compositor/compositor.gyp<http://codereview.chromium.org/8418022/diff/2001/ui/gfx/compositor/compositor.gyp>
> >
> >> File ui/gfx/compositor/compositor.**gyp (right):
> >>
> >
> >
> > http://codereview.chromium.**org/8418022/diff/2001/ui/gfx/**
> >
>
compositor/compositor.gyp#**newcode120<http://codereview.chromium.org/8418022/diff/2001/ui/gfx/compositor/compositor.gyp#newcode120>
> >
> >> ui/gfx/compositor/compositor.**gyp:120:
> >> '<(DEPTH)/base/allocator/**allocator.gyp:allocator',
> >> On 2011/11/17 21:14:20, oshima wrote:
> >> > backer, this is causing problem when building asan which requires asan
> >> > allocator. Do you know why we need this here?
> >>
> >
> >  This should be guarded by the condition 'linux_use_tcmalloc==1'.
> >>
> >
> > I have a fix in
>
http://codereview.chromium.**org/8565019/%3Chttp://codereview.chromium.org/85...
> unfortunately that
> > CL won't go in immediately. I'll rubber stamp LGTM any CL that fixes it.
> >
> >
>
http://codereview.chromium.**org/8418022/%3Chttp://codereview.chromium.org/84...>
> >