allocator.gyp target needs to be conditionally included in compositor.gyp

allocator.gyp target needs to be conditionally included in compositor.gyp

Changes the compositor.gyp file to only include the tcmalloc allocator on linux when use_linux_tcmalloc is specified.  This was conflicting with ASAN compile flags.

BUG=none
TEST=compile on linux with GYP_DEFINES='asan=1 linux_use_tcmalloc=0...'
TBR=oshima@chromium.org, backer@chromium.org


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110606

[oshima, 2011-11-17 22:22:31]

LGTM

http://codereview.chromium.org/8591029/diff/1/ui/gfx/compositor/compositor.gyp
File ui/gfx/compositor/compositor.gyp (right):

http://codereview.chromium.org/8591029/diff/1/ui/gfx/compositor/compositor.gy...
ui/gfx/compositor/compositor.gyp:122: 'dependencies': [
can you fix indent here?

http://codereview.chromium.org/8591029/diff/1/ui/gfx/compositor/compositor.gy...
ui/gfx/compositor/compositor.gyp:127: ['os_posix == 1 and OS != "mac"', {
It's a bit strange to be nested (could have just be
"os_posix == 1 and OS != "mac" and linux_use_tcmalloc==1")
but looks like this is common pattern.

[dhollowa, 2011-11-17 22:28:23]

http://codereview.chromium.org/8591029/diff/1/ui/gfx/compositor/compositor.gyp
File ui/gfx/compositor/compositor.gyp (right):

http://codereview.chromium.org/8591029/diff/1/ui/gfx/compositor/compositor.gy...
ui/gfx/compositor/compositor.gyp:122: 'dependencies': [
On 2011/11/17 22:22:31, oshima wrote:
> can you fix indent here?

Done.

http://codereview.chromium.org/8591029/diff/1/ui/gfx/compositor/compositor.gy...
ui/gfx/compositor/compositor.gyp:127: ['os_posix == 1 and OS != "mac"', {
On 2011/11/17 22:22:31, oshima wrote:
> It's a bit strange to be nested (could have just be
> "os_posix == 1 and OS != "mac" and linux_use_tcmalloc==1")
> but looks like this is common pattern.
> 

Yes.  I followed the pattern.

[commit-bot: I haz the power, 2011-11-17 22:31:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dhollowa@chromium.org/8591029/5001

[commit-bot: I haz the power, 2011-11-17 23:55:57]

Change committed as 110606