Issue 8417043: Add webkit_glue namespace. Improve some variable and test names.

Issue 8417043: Add webkit_glue namespace. Improve some variable and test names. (Closed)

Created:
9 years, 1 month ago by Greg Billock

Modified:
9 years, 1 month ago

Reviewers:
groby-ooo-7-16

CC:
chromium-reviews, Erik does not do reviews, mihaip+watch_chromium.org, Aaron Boodman, darin-cc_chromium.org, Paweł Hajdan Jr., dhollowa

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Add webkit_glue namespace. Improve some variable and test names. R=groby@chromium.org BUG=None TEST=*Intent*.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108180

Patch Set 2 : Review fixes and merge to head #

Patch Set 3 : Fix merge error #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+267 lines, -226 lines)			Patch
M	chrome/browser/intents/register_intent_handler_infobar_delegate.h	View		2 chunks	+6 lines, -5 lines	0 comments	Download
M	chrome/browser/intents/register_intent_handler_infobar_delegate.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/intents/register_intent_handler_infobar_delegate_unittest.cc	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/intents/web_intents_registry.h	View	1	3 chunks	+6 lines, -4 lines	0 comments	Download
M	chrome/browser/intents/web_intents_registry.cc	View	1	3 chunks	+11 lines, -9 lines	0 comments	Download
M	chrome/browser/intents/web_intents_registry_unittest.cc	View	1 2	7 chunks	+13 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/browser.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/intents/web_intent_picker_controller.h	View		2 chunks	+4 lines, -1 line	0 comments	Download
M	chrome/browser/ui/intents/web_intent_picker_controller.cc	View	1	3 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/intents/web_intent_picker_controller_browsertest.cc	View		1 chunk	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/intents/web_intent_picker_controller_unittest.cc	View	1	1 chunk	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/intents/web_intents_model.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/intents/web_intents_model.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/intents/web_intents_model_unittest.cc	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/webui/options/web_intents_settings_handler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/webdata/web_data_service.h	View	1	4 chunks	+7 lines, -5 lines	0 comments	Download
M	chrome/browser/webdata/web_data_service.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/webdata/web_data_service_unittest.cc	View	1	6 chunks	+23 lines, -22 lines	0 comments	Download
M	chrome/browser/webdata/web_intents_table.h	View	1	1 chunk	+11 lines, -9 lines	0 comments	Download
M	chrome/browser/webdata/web_intents_table.cc	View		5 chunks	+22 lines, -18 lines	0 comments	Download
M	chrome/browser/webdata/web_intents_table_unittest.cc	View		3 chunks	+75 lines, -72 lines	0 comments	Download
M	chrome/common/extensions/extension.h	View	1	3 chunks	+8 lines, -5 lines	0 comments	Download
M	chrome/common/extensions/extension.cc	View	1	3 chunks	+28 lines, -25 lines	0 comments	Download
M	chrome/common/extensions/extension_manifests_unittest.cc	View	1	1 chunk	+17 lines, -15 lines	0 comments	Download
M	webkit/glue/web_intent_service_data.h	View	1	2 chunks	+6 lines, -1 line	0 comments	Download
M	webkit/glue/web_intent_service_data.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

groby-ooo-7-16

LGTM with nits http://codereview.chromium.org/8417043/diff/1/chrome/browser/webdata/web_data_service_unittest.cc File chrome/browser/webdata/web_data_service_unittest.cc (right): http://codereview.chromium.org/8417043/diff/1/chrome/browser/webdata/web_data_service_unittest.cc#newcode174 chrome/browser/webdata/web_data_service_unittest.cc:174: std::vector<WebIntentServiceData> services; nit: should be services_ ...

9 years, 1 month ago (2011-10-31 20:53:37 UTC) #2

Greg Billock

http://codereview.chromium.org/8417043/diff/1/chrome/browser/webdata/web_data_service_unittest.cc File chrome/browser/webdata/web_data_service_unittest.cc (right): http://codereview.chromium.org/8417043/diff/1/chrome/browser/webdata/web_data_service_unittest.cc#newcode174 chrome/browser/webdata/web_data_service_unittest.cc:174: std::vector<WebIntentServiceData> services; On 2011/10/31 20:53:37, groby wrote: > nit: ...

9 years, 1 month ago (2011-11-01 17:11:16 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/8417043/9001

9 years, 1 month ago (2011-11-01 21:03:28 UTC) #5

Change committed as 108180

Expand Messages | Collapse Messages