chrome/browser/ui/intents/web_intent_picker_controller_browsertest.cc - Issue 8417043: Add webkit_glue namespace. Improve some variable and test names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/intents/web_intent_picker_controller_browsertest.cc

Issue 8417043: Add webkit_glue namespace. Improve some variable and test names. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix merge error Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/intents/web_intent_picker_controller.cc ('k') | chrome/browser/ui/intents/web_intent_picker_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/intents/web_intent_picker_controller_browsertest.cc

diff --git a/chrome/browser/ui/intents/web_intent_picker_controller_browsertest.cc b/chrome/browser/ui/intents/web_intent_picker_controller_browsertest.cc

index 6702c1282941d230b7c8b96088e556adc38fce45..07959fb1a70d639df6a2e637c3dbe8c0db86d623 100644

--- a/chrome/browser/ui/intents/web_intent_picker_controller_browsertest.cc

+++ b/chrome/browser/ui/intents/web_intent_picker_controller_browsertest.cc

@@ -63,11 +63,11 @@ class WebIntentPickerControllerBrowserTest : public InProcessBrowserTest {

protected:

void AddWebIntentService(const string16& action,

const GURL& service_url) {

- WebIntentServiceData web_intent_service_data;

- web_intent_service_data.action = action;

- web_intent_service_data.type = kType;

- web_intent_service_data.service_url = service_url;

- web_data_service_->AddWebIntent(web_intent_service_data);

+ webkit_glue::WebIntentServiceData service;

+ service.action = action;

+ service.type = kType;

+ service.service_url = service_url;

+ web_data_service_->AddWebIntent(service);

}

void SetPickerExpectations(int expected_service_count,