Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1074)

Unified Diff: media/video/video_decode_engine.h

Issue 8417016: Remove media::VideoDecodeContext as it has no implementation and is unused. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix players Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/video/video_decode_engine.h
diff --git a/media/video/video_decode_engine.h b/media/video/video_decode_engine.h
index cd1f9860402e4eafb716c2103d88d86abbfab13f..cb08f2ab0e4982267afb70d3581db32f5493752d 100644
--- a/media/video/video_decode_engine.h
+++ b/media/video/video_decode_engine.h
@@ -12,13 +12,9 @@
#include "media/base/video_frame.h"
#include "ui/gfx/size.h"
-class MessageLoop;
-
namespace media {
class Buffer;
-class VideoDecodeContext;
-
struct PipelineStatistics;
class MEDIA_EXPORT VideoDecodeEngine {
@@ -67,17 +63,9 @@ class MEDIA_EXPORT VideoDecodeEngine {
// Initialize the engine with specified configuration.
//
- // |decode_context| is used for allocation of VideoFrame.
- // It is important that |decode_context| is called only on |message_loop|.
- //
- // TODO(hclam): Currently refactoring code to use VideoDecodeContext so
- // |context| may be NULL in some cases.
- //
// Engine should call EventHandler::OnInitializeDone() whether the
// initialization operation finished successfully or not.
- virtual void Initialize(MessageLoop* message_loop,
Ami GONE FROM CHROMIUM 2011/10/28 16:47:31 What is up w/ dropping message_loop_ from the engi
scherkus (not reviewing) 2011/10/28 17:00:38 it's not even used by FFVDE haha
Ami GONE FROM CHROMIUM 2011/10/28 17:23:17 Wow.
- EventHandler* event_handler,
- VideoDecodeContext* context,
+ virtual void Initialize(EventHandler* event_handler,
const VideoDecoderConfig& config) = 0;
// Uninitialize the engine. Engine should destroy all resources and call

Powered by Google App Engine
This is Rietveld 408576698