aura: Comment noisy NOTIMPLEMENTEDs in NativeWidgetAura.

aura: Comment noisy NOTIMPLEMENTEDs in NativeWidgetAura.

This also wires up GetRestoredBounds().

BUG=99729
TEST=manual: less spam

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107735

[Ben Goodger (Google), 2011-10-28 04:19:12]

LGTM

On Thu, Oct 27, 2011 at 6:20 PM, <derat@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Description:
> aura: Comment noisy NOTIMPLEMENTEDs in NativeWidgetAura.
>
> This also wires up GetRestoredBounds().
>
> BUG=99729
> TEST=manual: less spam
>
>
> Please review this at
http://codereview.chromium.**org/8417014/<http://codereview.chromium.org/8417...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M ui/aura/window.h
>  M views/widget/native_widget_**aura.cc
>
>
> Index: ui/aura/window.h
> diff --git a/ui/aura/window.h b/ui/aura/window.h
> index a809f5df0dbc0a92769fd2b0e1c798**7c61a82dba..**
> daa8f06c54d361c91e33769869f85c**d8fe11ba60 100644
> --- a/ui/aura/window.h
> +++ b/ui/aura/window.h
> @@ -77,6 +77,7 @@ class AURA_EXPORT Window : public ui::LayerDelegate {
>   WindowDelegate* delegate() { return delegate_; }
>
>   const gfx::Rect& bounds() const;
> +  const gfx::Rect& restore_bounds() const { return restore_bounds_; }
>
>   Window* parent() { return parent_; }
>   const Window* parent() const { return parent_; }
> Index: views/widget/native_widget_**aura.cc
> diff --git a/views/widget/native_widget_**aura.cc
> b/views/widget/native_widget_**aura.cc
> index 2113872f11ad9873b79e4e4b4afbc2**380358e4c0..**
> 063f57a011aed25e591fa54a544639**07cf0e57a3 100644
> --- a/views/widget/native_widget_**aura.cc
> +++ b/views/widget/native_widget_**aura.cc
> @@ -157,7 +157,7 @@ void NativeWidgetAura::**ReorderLayers() {
>  }
>
>  void NativeWidgetAura::ViewRemoved(**View* view) {
> -//  NOTIMPLEMENTED();
> +  //NOTIMPLEMENTED();
>  }
>
>  void NativeWidgetAura::**SetNativeWindowProperty(const char* name, void*
> value) {
> @@ -175,14 +175,14 @@ TooltipManager* NativeWidgetAura::**GetTooltipManager()
> const {
>  }
>
>  bool NativeWidgetAura::**IsScreenReaderActive() const {
> -  NOTIMPLEMENTED();
> +  //NOTIMPLEMENTED();
>   return false;
>  }
>
>  void NativeWidgetAura::**SendNativeAccessibilityEvent(
>     View* view,
>     ui::AccessibilityTypes::Event event_type) {
> -  NOTIMPLEMENTED();
> +  //NOTIMPLEMENTED();
>  }
>
>  void NativeWidgetAura::**SetMouseCapture() {
> @@ -222,24 +222,24 @@ void NativeWidgetAura::**GetWindowPlacement(
>  }
>
>  void NativeWidgetAura::**SetWindowTitle(const string16& title) {
> -  NOTIMPLEMENTED();
> +  // Aura doesn't have native window frames.
>  }
>
>  void NativeWidgetAura::**SetWindowIcons(const SkBitmap& window_icon,
>                                      const SkBitmap& app_icon) {
> -  NOTIMPLEMENTED();
> +  // Aura doesn't have window icons.
>  }
>
>  void NativeWidgetAura::**SetAccessibleName(const string16& name) {
> -  NOTIMPLEMENTED();
> +  //NOTIMPLEMENTED();
>  }
>
>  void NativeWidgetAura::**SetAccessibleRole(ui::**AccessibilityTypes::Role
> role) {
> -  NOTIMPLEMENTED();
> +  //NOTIMPLEMENTED();
>  }
>
>  void NativeWidgetAura::**SetAccessibleState(ui::**AccessibilityTypes::State
> state) {
> -  NOTIMPLEMENTED();
> +  //NOTIMPLEMENTED();
>  }
>
>  void NativeWidgetAura::BecomeModal(**) {
> @@ -251,15 +251,12 @@ gfx::Rect NativeWidgetAura::**GetWindowScreenBounds()
> const {
>  }
>
>  gfx::Rect NativeWidgetAura::**GetClientAreaScreenBounds() const {
> -  // TODO(beng):
> -  NOTIMPLEMENTED();
> +  // In Aura, the entire window is the client area.
>   return window_->GetScreenBounds();
>  }
>
>  gfx::Rect NativeWidgetAura::**GetRestoredBounds() const {
> -  // TODO(beng):
> -  NOTIMPLEMENTED();
> -  return window_->bounds();
> +  return window_->restore_bounds();
>  }
>
>  void NativeWidgetAura::SetBounds(**const gfx::Rect& bounds) {
>
>
>