Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Unified Diff: views/widget/native_widget_aura.cc

Issue 8417014: aura: Comment noisy NOTIMPLEMENTEDs in NativeWidgetAura. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/aura/window.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: views/widget/native_widget_aura.cc
diff --git a/views/widget/native_widget_aura.cc b/views/widget/native_widget_aura.cc
index 2113872f11ad9873b79e4e4b4afbc2380358e4c0..063f57a011aed25e591fa54a54463907cf0e57a3 100644
--- a/views/widget/native_widget_aura.cc
+++ b/views/widget/native_widget_aura.cc
@@ -157,7 +157,7 @@ void NativeWidgetAura::ReorderLayers() {
}
void NativeWidgetAura::ViewRemoved(View* view) {
-// NOTIMPLEMENTED();
+ //NOTIMPLEMENTED();
}
void NativeWidgetAura::SetNativeWindowProperty(const char* name, void* value) {
@@ -175,14 +175,14 @@ TooltipManager* NativeWidgetAura::GetTooltipManager() const {
}
bool NativeWidgetAura::IsScreenReaderActive() const {
- NOTIMPLEMENTED();
+ //NOTIMPLEMENTED();
return false;
}
void NativeWidgetAura::SendNativeAccessibilityEvent(
View* view,
ui::AccessibilityTypes::Event event_type) {
- NOTIMPLEMENTED();
+ //NOTIMPLEMENTED();
}
void NativeWidgetAura::SetMouseCapture() {
@@ -222,24 +222,24 @@ void NativeWidgetAura::GetWindowPlacement(
}
void NativeWidgetAura::SetWindowTitle(const string16& title) {
- NOTIMPLEMENTED();
+ // Aura doesn't have native window frames.
}
void NativeWidgetAura::SetWindowIcons(const SkBitmap& window_icon,
const SkBitmap& app_icon) {
- NOTIMPLEMENTED();
+ // Aura doesn't have window icons.
}
void NativeWidgetAura::SetAccessibleName(const string16& name) {
- NOTIMPLEMENTED();
+ //NOTIMPLEMENTED();
}
void NativeWidgetAura::SetAccessibleRole(ui::AccessibilityTypes::Role role) {
- NOTIMPLEMENTED();
+ //NOTIMPLEMENTED();
}
void NativeWidgetAura::SetAccessibleState(ui::AccessibilityTypes::State state) {
- NOTIMPLEMENTED();
+ //NOTIMPLEMENTED();
}
void NativeWidgetAura::BecomeModal() {
@@ -251,15 +251,12 @@ gfx::Rect NativeWidgetAura::GetWindowScreenBounds() const {
}
gfx::Rect NativeWidgetAura::GetClientAreaScreenBounds() const {
- // TODO(beng):
- NOTIMPLEMENTED();
+ // In Aura, the entire window is the client area.
return window_->GetScreenBounds();
}
gfx::Rect NativeWidgetAura::GetRestoredBounds() const {
- // TODO(beng):
- NOTIMPLEMENTED();
- return window_->bounds();
+ return window_->restore_bounds();
}
void NativeWidgetAura::SetBounds(const gfx::Rect& bounds) {
« no previous file with comments | « ui/aura/window.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698