Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 8416054: Added booleans that indicate which GL extensions are available. (Closed)

Created:
9 years, 1 month ago by apatrick_chromium
Modified:
9 years, 1 month ago
CC:
chromium-reviews
Visibility:
Public.

Description

Added booleans that indicate which GL extensions are available. This is because some implementations of eglGetProcAddress do not return null for entry points that are not available. This gives a convenient and efficient way of determining whether a particular entry point can be called. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108153

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -8 lines) Patch
M gpu/command_buffer/service/gpu_scheduler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gfx/gl/generate_bindings.py View 1 5 chunks +18 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
apatrick_chromium
9 years, 1 month ago (2011-10-28 23:54:42 UTC) #1
Ken Russell (switch to Gerrit)
LGTM I'm pretty sure that there are other places in the code where we assume ...
9 years, 1 month ago (2011-10-29 01:48:07 UTC) #2
apatrick_chromium
9 years, 1 month ago (2011-11-01 18:19:15 UTC) #3
Yeah I was thinking about how to find them all. I could change the binding
macros from

#define glClearColor gfx::g_glClearColor

to

#define glClearColor(r, g, b, a) gfx::glClearColor(r, g, b, a)

Then failing to specify the arguments would be a preprocessor error. There might
still be some legit reasons to bind to the function pointers directly though,
perhaps in skia.

Powered by Google App Engine
This is Rietveld 408576698