Issue 8416049: Expect should still fail for non-asynchronous tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8416049: Expect should still fail for non-asynchronous tests. (Closed)

Created:
9 years, 1 month ago by Sheridan Rawlins

Modified:
9 years, 1 month ago

Reviewers:
flackr

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Expect should still fail for non-asynchronous tests. R=flackr@chromium.org BUG=99970 TEST=browser_tests --gtest_filter=WebUIAssertions*.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108005

Patch Set 1 #

Total comments: 1

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -6 lines)			Patch
	M	chrome/test/data/webui/assertions.js	View		1 chunk	+26 lines, -5 lines	1 comment	Download
	M	chrome/test/data/webui/test_api.js	View		1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Sheridan Rawlins

http://codereview.chromium.org/8416049/diff/1/chrome/test/data/webui/assertions.js File chrome/test/data/webui/assertions.js (right): http://codereview.chromium.org/8416049/diff/1/chrome/test/data/webui/assertions.js#newcode80 chrome/test/data/webui/assertions.js:80: // Test that an expect failure fails test. FYI, ...

9 years, 1 month ago (2011-10-28 20:51:20 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scr@chromium.org/8416049/1

9 years, 1 month ago (2011-10-31 18:43:28 UTC) #3

Change committed as 108005

Expand Messages | Collapse Messages