chrome/test/data/webui/test_api.js - Issue 8416049: Expect should still fail for non-asynchronous tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/webui/test_api.js

Issue 8416049: Expect should still fail for non-asynchronous tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/data/webui/test_api.js

diff --git a/chrome/test/data/webui/test_api.js b/chrome/test/data/webui/test_api.js

index 24f0adb42477975c5b1001cd3f3569319822a167..140efe7d4b5d9c1743d9ac1f96e095b6b39ba325 100644

--- a/chrome/test/data/webui/test_api.js

+++ b/chrome/test/data/webui/test_api.js

@@ -767,7 +767,10 @@ var testing = {};

if (testBody != RUN_TEST_F) {

console.log('Running test ' + testName);

}

- var result = runTestFunction(testFunction, testBody, testArguments, true);

+ // Async allow expect errors, but not assert errors.

+ var result = runTestFunction(testFunction, testBody, testArguments,

+ isAsync);

if (!isAsync || !result[0])

testDone(result);

return true;